Steven,
Thanks. I am using notes from this link for “git commit”: https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Commit_to_your_local_repo which makes no mention of specific Subject nor a Type in “git commit”. I did check the MAINTAINERS file and also the ERROR below which asked for a feature-id. I used “feature” for feature-id in the Subject of “git commit”. Could you please give me an complete example for “git commit” command with “Type:” to use for Lawful Intercept and Subject etc. required – thanks. This crash is 100% reproducible with latest vpp. Hemant From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of steven luong via lists.fd.io Sent: Tuesday, April 27, 2021 4:37 PM To: hem...@mnkcg.com; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] lawful intercept Your commit subject line is missing a component name. The commit comment is missing “Type:”. Steven From: <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > on behalf of "hemant via lists.fd.io" <hemant=mnkcg....@lists.fd.io <mailto:hemant=mnkcg....@lists.fd.io> > Reply-To: "hem...@mnkcg.com <mailto:hem...@mnkcg.com> " <hem...@mnkcg.com <mailto:hem...@mnkcg.com> > Date: Tuesday, April 27, 2021 at 12:56 PM To: "vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> " <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > Subject: Re: [vpp-dev] lawful intercept Newer review for LI crash: https://gerrit.fd.io/r/c/vpp/+/32144 The build failed with the error below which I have tried to fix with the new review above. However, the build still fails with the same error below. I used “git commit -m "feature" -m "Fix crash in LI CLI" -s” with newer review but still I get the “Subject” line failure. =============================== ERROR =============================== 15:16:26 git commit 'Subject:' line must contain at least one known feature id. 15:16:26 feature id(s) must be listed before ':' and space delimited 15:16:26 if more than one is listed. 15:16:26 Please refer to the MAINTAINERS file (I: lines) for known feature ids. 15:16:26 =============================== ERROR =============================== Hemant From: hem...@mnkcg.com <mailto:hem...@mnkcg.com> <hem...@mnkcg.com <mailto:hem...@mnkcg.com> > Sent: Tuesday, April 27, 2021 3:26 PM To: hem...@mnkcg.com <mailto:hem...@mnkcg.com> ; vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: RE: [vpp-dev] lawful intercept During the morning my machine was down for maintenance. Thereafter, I used gdb and set a breakpoint in li_hit_node() and setup LI using CLI. The breakpoint is not hit even when I am sending traffic to match LI-configured src IP. I have actually developed LI for Cisco CPP asic and know how to use it. It would be good for anyone to reply if they have been successful with using VPP LI. Also, I could crash the LI code when I configure LI CLI once and then invoked the same CLI again. On the 2nd invocation the code crashes on this line: https://git.fd.io/vpp/tree/src/vnet/lawful-intercept/lawful_intercept.c#n62 I have issued a code review with fix: https://gerrit.fd.io/r/c/vpp/+/32143 Also, before sending out the review, I did use “make checkstyle” and fixed style issues. Then “make checkstyle” passed. But after issuing the code review, VPP automated build report a style failure – go figure… Hemant From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > On Behalf Of hemant via lists.fd.io Sent: Tuesday, April 27, 2021 1:01 PM To: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] lawful intercept Does VPP CSIT test LI or what is Lawful Intercept? I used the LI CLI shown at the link below. The CLI use did not incur any error. However, when I send packets, the packets are not getting tapped. “trace add dpdk-input” does not show any “LI_HIT” trace. https://docs.fd.io/vpp/17.04/clicmd_src_vnet_lawful-intercept.html I am using a fairly recent (few weeks behind latest) VPP repo. Hemant
smime.p7s
Description: S/MIME cryptographic signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19296): https://lists.fd.io/g/vpp-dev/message/19296 Mute This Topic: https://lists.fd.io/mt/82408851/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
