Hi Paul, > I'd like to propose three more changes/cleanup to the api files/vppapigen. > > 1. I'd like to remove the logic in vpppigen that imperatively declares the > service definitions. Instead of calculating the values, we would output the > necessary values to be added to the api file.
Yes, you could do that, although I think I would introduce it for new APIs / changed APIs. > 2. I'd like to change the existing message definitions to use the > corresponding enums in place of the primitives that they decay to. > u8 dscp -> vl_api_dscp_t dscp > > 3. I'd like to change the flag type enums to use the api enumflag type. I don't quite see how you can do that without breaking consumers. For new/changed APIs sure. Best regards, Ole
signature.asc
Description: Message signed with OpenPGP
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19244): https://lists.fd.io/g/vpp-dev/message/19244 Mute This Topic: https://lists.fd.io/mt/82107376/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
