+1 to DaveW’s comments.
Hemant From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Dave Wallace Sent: Thursday, March 25, 2021 4:15 PM To: dmar...@me.com; vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] keeping tests outside of src/ Hi Damjan, This initiative originated with the wider adoption of plugin development at the request of Dave Barach to allow the development of plugins outside the VPP repo. After completing the job for plugins, there were several requests to extend that to all of the features. Presumably this was coupled with the desire to migrate feature source code from vnet into the plugin arena, but I don't recall all of the details of the discussion. Unfortunately, this effort stalled across several releases due to lack of cycles and I'm just now in the process of completing the job. I'm perfectly ok accepting a -2 for test code that maintainers prefer to leave in .../vpp/test, but I don't see the original requirement to co-locate plugin source & test code going away. So the majority of the feature source & test code will remain structured that way and the end result will be inconsistent at best. Personally, I think that it makes sense to continue to move features source, test code, and documentation to be co-located in a modular and consistent sub-tree structure. I also see value in migrating features out of vnet into the plugin sub-tree. For what its worth, the changes to test/Makefile gather all of the source as soft links into the build tree (.../vpp/build-root/build-test/src), but I understand that is not the same your original plan. Thanks, -daw- On 3/25/2021 3:16 PM, Damjan Marion via lists.fd.io wrote: Hi, It may be that it is not discussed or i was just ignorant, but I noticed that there is ongoing activity to scatter tests all across the src/. When I started "make test" long long time ago i intentionally put it to separate tree following the pattern from other projects and to be honest it makes me more sense that all tests are contained in the separate tree. Are we sure that this test file scatter activity is right thing to do? Anyone aware of any other project doing the same? — Damjan
smime.p7s
Description: S/MIME cryptographic signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19030): https://lists.fd.io/g/vpp-dev/message/19030 Mute This Topic: https://lists.fd.io/mt/81611239/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
