Hi Ole, Thank you for this, but it is not enough. I don't mean that to come across ungratefully, but it doesn't fix the problem.
We need to also remove backward compatible tags from the enums in the .api files. The need for this arose from the fact that enums and enum flags got mixed together a while back. An enum flag is backward compatible, in that it's size never changes without a redefinition in the .api file. An enum, on the other hand, is a list of values, and 5 elements != 6 elements. A manifest is not a CRC. Vppapigen could trivially generate a separate manifest with custom logic without breaking the metadata of the api. I would not recommend that route. I already did the work of supporting plugins with vppapigen which was already merged, as well as turning vppapigen into a module [0] which is importable. I stopped pursuing it because the community feedback was against replacing the existing symlink in the build. I instead published a fork of it on pypi: [1]. I would prefer that there was only one code base. The rationale behind refactoring and contributing the code was to empower anyone (like say CSIT) to have control over how they wanted to consume the data. The csit job could run its own manifest generating logic based on their own needs and the two stay loosely coupled. [0] https://gerrit.fd.io/r/c/vpp/+/30080 [1] https://pypi.org/project/vppapigen/ Paul On Fri, Mar 5, 2021 at 4:22 AM Ole Troan <otr...@employees.org> wrote: > API users, > > This summer we found an error in the crc generation and to avoid forcing > API users to update their manifests on short notice I put in 9f84e70c6d. > Which "cheats" and returns the old crc value instead of the correct crc > value for a set of messages. > > https://git.fd.io/vpp/tree/src/tools/vppapigen/vppapigen.py#n1143 > > > In time for the next release I'd like to remove the "crc compatibility > table" from the API compiler. > > Paul has already a patch for that: > https://gerrit.fd.io/r/c/vpp/+/30345 > > The APIs themselves will not change, only the CRCs. This would affect > anyone maintaining manifests. > I know CSIT is affected, but are there others too that will be affected by > such a change? > > I'll leave this issue open for 2 weeks or so, and unless there are > objections I'd like to have 30345 merged before next release. > > Best regards, > Ole > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18867): https://lists.fd.io/g/vpp-dev/message/18867 Mute This Topic: https://lists.fd.io/mt/81108231/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
