Wow, this is a great catch, Ben! Kudos! 👍

--a

> On 11 Feb 2021, at 20:18, Benoit Ganne (bganne) via lists.fd.io 
> <bganne=cisco....@lists.fd.io> wrote:
> 
> Hi Dave,
> 
>> There are still 6 ikev2 test failures from this test run that need to be
>> resolved.
> 
> I identified the issue: undefined behaviour + aggressive gcc optimization.
> The tentative fix is here: https://gerrit.fd.io/r/c/vpp/+/31240
> 
> Note that for this to happen, you need both:
> - compile with gcc
> - use gcc memcpy builtin
> This is the case for ARM64 but not x86, as we do not use gcc memcpy builtin 
> on x86.
> 
> It looks like there are other cases where we call memcpy with NULL pointers: 
> https://gerrit.fd.io/r/c/vpp/+/31241
> I am going to chase them down.
> 
> Best
> ben
> 
> 
> 
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18733): https://lists.fd.io/g/vpp-dev/message/18733
Mute This Topic: https://lists.fd.io/mt/80495347/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to