Hi Pim. If you look at your change, it was labeled -1. When you dig through the logs, you will see that the commit message needs to be updated. The title needs to start with build: and Type: should be improvement. After it verifies with a +1, you are ready to reach out to a maintainer.
See .git_commit_template.txt for more info. If you look in the maintainers file, you will see: Build System I: build M: Damjan Marion <damar...@cisco.com> F: Makefile F: src/CMakeLists.txt F: src/cmake/ F: build/ Paul On Mon, Dec 28, 2020 at 6:21 PM Pim van Pelt <p...@ipng.nl> wrote: > Hoi, > > After upgrading my workstation to `Groovy Gorilla`, I noticed that libffi > got changed. To be able to compile on Ubuntu 20.10, adding a small > OS_VERSION_ID override is necessary. > See https://gerrit.fd.io/r/c/vpp/+/30552 for the diff on toplevel > Makefile. This is my first change to VPP and I'm following the wiki > <https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code> > but > unsure who to contact (SMEs page > <https://wiki.fd.io/view/VPP/Committers/SMEs> was useful, but not for the > build subsystem itself). Closest activity I could find was ayourtch@ due > to the upcoming 21.01 release. > > If somebody can help me navigate and assign a reviewer, I'd be grateful. > > groet, > Pim > > > -- > Pim van Pelt <p...@ipng.nl> > PBVP1-RIPE - http://www.ipng.nl/ > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18450): https://lists.fd.io/g/vpp-dev/message/18450 Mute This Topic: https://lists.fd.io/mt/79280624/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
