Thanks Elias, merged.
Would you mind fixing that in master too?

Cheers,
Ole

> On 30 Nov 2020, at 21:41, Elias Rudberg <elias.rudb...@bahnhof.net> wrote:
> 
> Hi Ole, thanks for your answer.
> 
>> /w/workspace/vpp-verify-2009-ubuntu1804-x86_64/build-root/install-
>> vpp-native/vpp/include/vpp-api/client/stat_client.h:107:11: error:
>> pointer of type ‘void *’ used in arithmetic [-Werror=pointer-arith]
>>       ((p + sizeof (p)) < ((void *) sm->shared_header + sm-
>>> memory_size)))
>> 
>>         ~~^~~~~~~~~~
>> 
>> Doing pointer arithmetic on an incomplete type (void) isn't entirely
>> kosher.
>> GCC supports it, and you could disable the warning.
>> But the correct-est approach would be to cast it to a type with size
>> 1.
> 
> After adding some (char *) casts in stat_segment_adjust() it passed the
> tests, please have a look: https://gerrit.fd.io/r/c/vpp/+/30161
> 
> Best regards,
> Elias
> 

Attachment: signature.asc
Description: Message signed with OpenPGP

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18204): https://lists.fd.io/g/vpp-dev/message/18204
Mute This Topic: https://lists.fd.io/mt/78601259/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to