A naive implementation of that will break all of the CRC for the affected messages, which effectively means abandoning the message stability process.
--a > On 25 Nov 2020, at 17:27, Paul Vinciguerra <pvi...@vinciconsulting.com> wrote: > > > I would like to socialize the idea of removing the backwards_compatible > option from the .api files before the upcoming and any future releases. > > The commit message states: > This allows adding backwards compatible (as guaranteed by the developer) > enums. > The enums marked backwards compatible are not considered in the CRC > calculation. > > Because it is the widespread practice of the VPP comitter community to merge > commits without Maintainer approval, it is practically not possible for the > developer to assert his/her "guarantee". This is a potentially risky area. > > If we remove these tags from the .api files before the next release, we can > guarantee a "golden image" of sorts, for lack of a better analogy, of crc > values. > > After the release, backwards_compatible could be used for subsequent > additions, again being removed before the next release is cut. > > Does a repo exist with the code used for verification while "cutting" a > release? > > I don't mind putting up a changeset. > > Paul > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18140): https://lists.fd.io/g/vpp-dev/message/18140 Mute This Topic: https://lists.fd.io/mt/78503177/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
