> something has gone wrong here. Yeah, sorry for the confusion.
I consult the maintainers file when double-checking who to add as reviewers. But when I think the maintainers file is outdated, I do not hesitate to add [0] or remove [1] anybody based on my (limited) perception. Usually I am too focused on fixing VPP to properly think about the process of editing the maintainers file. Do we have a document with guidelines related to that? Vratko. [0] https://gerrit.fd.io/r/c/vpp/+/20366 [1] https://gerrit.fd.io/r/c/vpp/+/22672 From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Ole Troan Sent: Monday, 2020-November-16 15:16 To: Paul Vinciguerra <pvi...@vinciconsulting.com> Cc: Vratko Polak -X (vrpolak - PANTHEON TECH SRO at Cisco) <vrpo...@cisco.com>; Marcos - Mgiga <mar...@mgiga.com.br>; vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] Python API modules Hi Paul, > He/Vratko removed me as one of the maintainers of papi. > https://gerrit.fd.io/r/c/vpp/+/22672. I'm cool with not being a maintainer, > kinda funny that it was stuffed into another changeset. I have been called > out repeatedly for submitting unrelated changes ;) My apologies, something has gone wrong here. I wasn't even aware that you got removed. I have reviewed the history and spoken to Vratko to understand what has happened here. Vratko was editing the MAINTAINERS file and made changes in good faith reflecting what he believed was the current state. Expecting reviewers to comment. I missed that in code review, and the patch went in. I do not believe that's a correct way of doing things, and since this was done in error, I'd like to add you back as maintainer for PAPI. That is revert to the state prior to that patch. Apologies again, and let's fix that error. Best regards, Ole
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18043): https://lists.fd.io/g/vpp-dev/message/18043 Mute This Topic: https://lists.fd.io/mt/78229638/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
