Removed. I'm glad it works for you. Could I ask for a quid pro quo? Mark the existing ipsec interface APIs as deprecated in the new scheme.
/neale tpyed by my fat tumhbs ________________________________ From: Dave Barach (dbarach) <dbar...@cisco.com> Sent: Monday, July 20, 2020 2:50:09 PM To: Christian Hopps <cho...@chopps.org>; vpp-dev <vpp-dev@lists.fd.io> Cc: Neale Ranns (nranns) <nra...@cisco.com> Subject: RE: [vpp-dev] Regarding new ipsec interface patch We can merge the patch as soon as Neale removes his -2 from it... D. -----Original Message----- From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Christian Hopps Sent: Monday, July 20, 2020 7:50 AM To: vpp-dev <vpp-dev@lists.fd.io> Cc: Christian Hopps <cho...@chopps.org>; Neale Ranns (nranns) <nra...@cisco.com> Subject: [vpp-dev] Regarding new ipsec interface patch Hi vpp-dev, In the interest of expressing the community support that Neale asked for https://gerrit.fd.io/r/c/vpp/+/27795 Looks good to me. It may need some minor additional development to polish some rough edges, but I have been able to use it with a few IPTFS specific modifications to implement the same route-based functionality that I had in 1908. As was asked in the last VPP dev meeting, the risk of collateral damage is extremely low, and it would be good to get it merged to master now to expose this in any case (the changes are minimal outside the new ipsec_itf.[ch] files). So my recommendation is to merge now to get good soak time prior to 2009 (LTS) being cut. Thanks, Chris.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#17016): https://lists.fd.io/g/vpp-dev/message/17016 Mute This Topic: https://lists.fd.io/mt/75679898/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
