See https://gerrit.fd.io/r/c/vpp/+/27467.
Here's the commit message: vlib: stop inlining vlib_add_trace(...) Packet tracing performance doesn't justify inlining vlib_add_trace(...) over 500 times. It makes a 15% text-segment size difference in a representative use-case: Inline: $ size .../vnet_skx.dir/ipsec/ipsec_input.c.o text data bss dec hex filename 6831 80 0 6911 1aff .../vnet_skx.dir/ipsec/ipsec_input.c.o Not inline: $ size .../vnet_skx.dir/ipsec/ipsec_input.c.o text data bss dec hex filename 5776 80 0 5856 16e0 .../vnet_skx.dir/ipsec/ipsec_input.c.o Retain the original code as vlib_add_trace_inline, instantiate once as vlib_add_trace. Type: refactor Signed-off-by: Dave Barach Change-Id: Iaf431dbf00c4aad03663d86f9dd1322e84d03962 From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Dave Barach via lists.fd.io Sent: Monday, June 8, 2020 10:13 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] vlib_add_trace(...) - stop inlining? Folks, It looks to me like inlining vlib_add_trace(...) is probably a mistake in terms of code bloat. Does anyone hate the idea of changing it to a standard function? Thanks... Dave
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16688): https://lists.fd.io/g/vpp-dev/message/16688 Mute This Topic: https://lists.fd.io/mt/74752449/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
