FWIW, I had documented (mostly for myself) the process I used from a while ago: http://stdio.be/blog/2017-06-06-Creating-drafts-and-changes-for-VPP/
It’s a bit more typing, but works well over HTTPS (IIRC git-review was very insistent on SSH to gerrit port.. it does ask for the password - which is the same as the GUI - but this ensures I remember it :-) so I had never gotten used to using git-review. I wonder if the “publish” namespace is some sort of older feature left for compatibility... (“refs/for/drafts” stopped working about half a year ago, IIRC) I heard on the grapevine upgrading the git-review to 2.0 seemed to do the trick, maybe the folks that did it might chime in with some first-hand experiences... --a > On 14 May 2020, at 12:02, Juraj Linkeš <juraj.lin...@pantheon.tech> wrote: > > Hi folks, > > I've ran into the same issue when trying to submit a CSIT patch after > upgrading my Debian distro (which also updated git review). It turns out that > my git review (version 1.25.0) is using improper default gerrit namespace. > From git review 1.27.0 release notes [0]: > Update default gerrit namespace for newer gerrit. According to Gerrit > documentation for 2.15.3, refs/for/’branch’ should be used when pushing > changes to Gerrit instead of refs/publish/’branch’. > > I didn't figure out how to configure the default namespace for git review > (maybe it could be done in .gitreview, but the docs don't mention that) so I > just submitted the change manually: > git push ssh://juraj.lin...@gerrit.fd.io:29418/csit.git > HEAD:refs/for/master%wip -o topic=1n-tx2_doc_update > > Regards, > Juraj > > [0] > https://docs.openstack.org/infra/git-review/releasenotes.html#relnotes-1-27-0 > >> -----Original Message----- >> From: Govindarajan Mohandoss <govindarajan.mohand...@arm.com> >> Sent: Thursday, May 14, 2020 4:31 AM >> To: Luke, Chris <chris_l...@comcast.com>; vpp-dev <vpp-dev@lists.fd.io> >> Cc: nd <n...@arm.com>; nd <n...@arm.com> >> Subject: Re: [vpp-dev] Help with creating patch >> >> Hi Chris, >> I didn't create a local branch. Thanks !! >> I didn’t change the subject thinking that it could be related to code >> freeze. >> Sorry for that. >> >> Thanks >> Govind >> >>> -----Original Message----- >>> From: Luke, Chris <chris_l...@comcast.com> >>> Sent: Wednesday, May 13, 2020 9:12 PM >>> To: Govindarajan Mohandoss <govindarajan.mohand...@arm.com>; vpp- >> dev >>> <vpp-dev@lists.fd.io> >>> Cc: nd <n...@arm.com> >>> Subject: RE: [vpp-dev] Help with creating patch >>> >>> Govind, >>> >>> Did you create a branch locally before making a commit? It looks like >>> you tried to push to master which won't work. A typical workflow >>> involves creating a local branch, making some changes and commits and >>> then pushing to Gerrit. >>> >>> Also, I changed the email subject; you should really have started a >>> new thread instead of replying to an existing thread with something >>> unrelated. >>> >>> Chris. >>> >>> -----Original Message----- >>> From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of >>> Govindarajan Mohandoss >>> Sent: Wednesday, May 13, 2020 19:24 >>> To: ayour...@gmail.com; vpp-dev <vpp-dev@lists.fd.io> >>> Cc: nd <n...@arm.com> >>> Subject: [EXTERNAL] Re: [vpp-dev] VPP 20.05 RC1 milestone is complete! >>> RC2 >>> - on Wednesday 20th May >>> >>> Hello Maintainers, >>> I am doing the patch submission for the first time. >>> I am following the page >>> https://urldefense.com/v3/__https://wiki.fd.io/view/VPP/Pulling,_Build >>> ing,_ >>> Running,_Hacking_and_Pushing_VPP_Code*Pulling__;Iw!!CQl3mcHX2A!X_Yl >>> Df6H02w8Ew6AQDrBpiMP7UZ5XJeDWGNgAaY0wqMSqos0VyWPgbGH8cP27P >>> ol6w$ and getting the error below. Can you please help to fix this ? >>> >>> #:~/vpp_external/vpp$ git review >>> remote: error: branch refs/publish/master: >>> remote: You need 'Create' rights to create new references. >>> remote: User: mgovind >>> remote: Contact an administrator to fix the permissions >>> remote: >>> remote: Processing changes: refs: 1 >>> remote: Processing changes: refs: 1, done To ssh://gerrit.fd.io:29418/vpp >>> ! [remote rejected] HEAD -> refs/publish/master (prohibited by Gerrit: >>> not >>> permitted: create) >>> error: failed to push some refs to 'ssh://mgov...@gerrit.fd.io:29418/vpp' >>> >>> Thanks >>> Govind >>> >>>> -----Original Message----- >>>> From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Andrew >>>> Yourtchenko via lists.fd.io >>>> Sent: Wednesday, May 13, 2020 6:05 PM >>>> To: vpp-dev <vpp-dev@lists.fd.io> >>>> Subject: [vpp-dev] VPP 20.05 RC1 milestone is complete! RC2 - on >>>> Wednesday 20th May >>>> >>>> Hi all, >>>> >>>> This is to announce that the VPP 20.05 RC1 milestone is complete! >>>> >>>> The newly created stable/2005 branch is ready for your fixes in >>>> preparation for the RC2 milestone. >>>> >>>> They need to have a Jira ticket for the issue, and to avoid >>>> forgetting adding them to master, where practical, *should* be first >>>> merged there and then cherry-picked into the stable/2005 branch - >>>> but as soon as the Jira ticket is mentioned in the commit message >>>> and the fix ends up in both master and >>>> stable/2005 (and if it is important/urgent - maybe earlier >>>> branches), then either order is fine. >>>> >>>> The installation packages for the RC1 for Ubuntu 18.04 and Centos 7 >>>> from the new branch are available on >>>> https://urldefense.com/v3/__https://packagecloud.io/fdio/2005/__;!!C >>>> Ql >>>> >>> 3mcHX2A!X_YlDf6H02w8Ew6AQDrBpiMP7UZ5XJeDWGNgAaY0wqMSqos0Vy >>> WPgbGH8cM1me >>>> QxkA$ >>>> >>>> The master branch is open for all commits. >>>> >>>> Our next milestone for VPP 20.05 is RC2, happening next Wednesday >>>> 20th May. >>>> >>>> Thanks a lot to Vanessa Valderrama, Dave Wallace and Ed Warnicke for >>>> the help! >>>> >>>> --a >>>> /* Your friendly 2005 release manager */ >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16378): https://lists.fd.io/g/vpp-dev/message/16378 Mute This Topic: https://lists.fd.io/mt/74197290/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
