Nice catch. TBH it won’t make much difference, but the code is clearly wrong. I’ll push a patch.
Dave From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of xiapengli...@gmail.com Sent: Friday, March 20, 2020 11:32 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] regarding disable_trace in vppinfra/dlmalloc.c Sorry to bother you experts:(, but when I read dlmalloc, just curious about why disable_trace was setting the USE_TRACE_BIT instead of unsetting... #define enable_trace(M) ((M)->mflags |= USE_TRACE_BIT) #define disable_trace(M) ((M)->mflags |= USE_TRACE_BIT)
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15832): https://lists.fd.io/g/vpp-dev/message/15832 Mute This Topic: https://lists.fd.io/mt/72438803/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
