Hi Klement, Thanks for the patch file. The fix works. Now I could see that once BFD session goes DOWN due to inactivity timer, remote discriminator is set 0 in BFD control packet.
On Fri, Jan 17, 2020 at 3:37 PM Klement Sekera -X (ksekera - PANTHEON TECH SRO at Cisco) <ksek...@cisco.com> wrote: > Hi, > > thank you for your report. > > Can you please apply this fix and verify that the behaviour is now correct? > > https://gerrit.fd.io/r/c/vpp/+/24388 > > Thanks, > Klement > > > On 17 Jan 2020, at 07:04, sont...@gmail.com wrote: > > > > Hi, > > > > I have observed an incorrect behavior in BFD code of VPP. > > I have brought BFD session UP between VPP and peer router. > > Due to interface shutdown on peer router BFD session on VPP goes to DOWN > state. > > Once it goes to DOWN state, it is continuously sending control packets > using its old remote discriminator in its control packet's "Your > Discriminator" field. > > This is a wrong behavior. Below RFC section tells that once BFD goes > DOWN due to non-receipt of BFD control packet, "Your Discriminator" field > should be set to zero. > > > > RFC 5880 6.8.1. State Variables > > > > > > bfd.RemoteDiscr > > > > The remote discriminator for this BFD session. This is the > > discriminator chosen by the remote system, and is totally opaque > > to the local system. This MUST be initialized to zero. If a > > period of a Detection Time passes without the receipt of a valid, > > authenticated BFD packet from the remote system, this variable > > MUST be set to zero. > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#15201): https://lists.fd.io/g/vpp-dev/message/15201 Mute This Topic: https://lists.fd.io/mt/69820780/21656 Mute #vpp: https://lists.fd.io/mk?hashtag=vpp&subid=1480452 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
