Jan/Vratko,
I spent the past several hours attempting to debug this issue. When
testing locally, using vpp master HEAD and csit oper-191209, I was able
to reproduce the problem when running
csit/resources/tools/integrated/check_crc.py
After attempting several iterations of reverting [0] and/or [1], I found
that adding the crc's that were changed in [0] to the main collection in
csit/resources/api/vpp/supported_crcs.yaml would pass locally.
Unfortunately when I pushed the patch [2], it failed to pass the crc
check in the csit-vpp-device-master-ubuntu1804-1n-skx verify job [2]
(which I subsequently abandoned).
The changes in [1], don't look correct to me, since they are not related
to gerrit 21706/17. I would think they either belong in their own
collection or the main collection should be modified with the new crcs
and not the ones in the "21706/17" collection. I tried the latter
experiment but the verify check failed locally.
At this point, it seems to me that there is a bug in the VppApiChecker
but it is not clear to me where this root cause is when looking at the
code. Or perhaps my local runtime environment is not correct. I'll let
you investigate further.
Hopefully this will help you resolve the issue quicker.
Thanks,
-daw-
[0] https://gerrit.fd.io/r/c/csit/+/23914
[1] https://gerrit.fd.io/r/c/csit/+/23921
[2] https://gerrit.fd.io/r/c/csit/+/23926
On 12/10/2019 9:03 AM, Dave Barach via Lists.Fd.Io wrote:
Folks,
This patch (among others) https://gerrit.fd.io/r/c/vpp/+/23625 changes
zero APIs, but fails API CRC validation.
Please fix AYEC. We’re dead in the water.
Thanks... Dave**
**
*04:37:59*/w/workspace/vpp-csit-verify-api-crc-master/src/tools/vppapigen/generate_json.py
*04:38:10*Searching '/w/workspace/vpp-csit-verify-api-crc-master/src'
for .api files.
*04:38:10*json files written to:
/w/workspace/vpp-csit-verify-api-crc-master/build-root/install-vpp-native/vpp/share/vpp/api/.
*04:38:10*+++ python3 csit/resources/tools/integrated/check_crc.py
*04:38:11*RuntimeError:
*04:38:11*Incompatible API CRCs found in .api.json files:
*04:38:11*{
*04:38:11* "ip_address_details":"0xb1199745",
*04:38:11* "ip_address_dump":"0x2d033de4",
*04:38:11* "ip_neighbor_add_del":"0x105518b6",
*04:38:11* "ip_route_add_del":"0xc1ff832d",
*04:38:11* "ip_table_add_del":"0x0ffdaec0",
*04:38:11* "sw_interface_ip6nd_ra_config":"0x3eb00b1c"
*04:38:11*}
*04:38:11*RuntimeError('Incompatible API CRCs found in .api.json
files:\n{\n "ip_address_details":"0xb1199745",\n
"ip_address_dump":"0x2d033de4",\n
"ip_neighbor_add_del":"0x105518b6",\n
"ip_route_add_del":"0xc1ff832d",\n "ip_table_add_del":"0x0ffdaec0",\n
"sw_interface_ip6nd_ra_config":"0x3eb00b1c"\n}',)
*04:38:11*
*04:38:11*@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
*04:38:11*
*04:38:11*VPP CSIT API CHECK FAIL!
*04:38:11*
*04:38:11*This means the patch under test has missing messages,
*04:38:11*or messages with unexpected CRCs compared to what CSIT needs.
*04:38:11*Either this Change and/or its ancestors were editing .api files,
*04:38:11*or your chain is not rebased upon the recent enough VPP
codebase.
*04:38:11*
*04:38:11*Please rebase the patch to see if that fixes the problem.
*04:38:11*If that fails email csit-...@lists.fd.io for a new
*04:38:11*operational branch supporting the api changes.
*04:38:11*
*04:38:11*@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
*04:38:11*Build step 'Execute shell' marked build as failure
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14852): https://lists.fd.io/g/vpp-dev/message/14852
Mute This Topic: https://lists.fd.io/mt/67971752/675079
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14858): https://lists.fd.io/g/vpp-dev/message/14858
Mute This Topic: https://lists.fd.io/mt/67971752/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
