> a +2 triggers a pre-commit gate where VOM and the dist builds and the > extended tests are run. > If everything passes, the change is merged, if not, the +2 is removed.
+1 to that, but I highly doubt Gerrit supports such a workflow. Additional features we would like to have: + Manual trigger to run the extended tests without also merging, (for debugging purposes after previous extended tests failed). + The gate job rebases on HEAD and only one run is allowed at a time (to avoid merge errors). + The gate job squashes multiple pending changes before testing (to keep up with the high frequency of +2 without introducing long queues). Vratko. From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Paul Vinciguerra Sent: Tuesday, November 19, 2019 12:10 PM To: Paul Vinciguerra <pvi...@vinciconsulting.com> Cc: Dave Wallace <dwallac...@gmail.com>; vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] Requirements for DPDK pmd/feature testing in CSIT vpp-device-test jobs Can we expand this discussion to discuss the VPP CI workflow? I would like to see a decoupling of development and integration. As I mentioned the other day, It would be great if we could rebuild the containers whenever a commit updated the Makefile or the requirements.txt files. I'd also like to throw out the idea of breaking up the verify job. I think that if we were to remove VOM and the dist builds from verify and change the workflow so that a +2 triggers a pre-commit gate where VOM and the dist builds and the extended tests are run. If everything passes, the change is merged, if not, the +2 is removed. The existing csit job could be non-voting (so the csit folks could have a heads up) in the first phase, and voting in pre-commit-phase. Paul On Mon, Nov 18, 2019 at 12:18 PM Paul Vinciguerra via Lists.Fd.Io<http://Lists.Fd.Io> <pvinci=vinciconsulting....@lists.fd.io<mailto:vinciconsulting....@lists.fd.io>> wrote: Hi Dave. Where does the vpp-device-test live? On Mon, Nov 18, 2019 at 11:13 AM Dave Wallace <dwallac...@gmail.com<mailto:dwallac...@gmail.com>> wrote: Folks, Per the topic in last week's monthly VPP community meeting, the topic of DPDK pmd/feature testing in the CSIT devicetest job was discussed in the most recent CSIT community meeting (Wed 11/13). In the beginning of the VPP project, DPDK pmd/feature testing was performed in the VIRL based CSIT test suites. DPDK was moved from the VPP core feature set into a plugin in VPP 17.04 and in later releases native device drivers were implemented. Subsequently, DPDK testing was removed from the CSIT VIRL tests. Also the CSIT team put a plan put in place for all of the VIRL tests to be moved and the VIRL servers re-purposed. In addition, the CSIT vpp-device-test job was created to provide test coverage of device level VPP features that cannot be tested in VPP's 'make test' framework. The plan for re-purposing the VIRL servers is complete and the vpp-device-test job is slated to become voting once it is stable enough for continuous-integration testing. The CSIT team would like input from the VPP community on exactly what DPDK PMD's and/or features are required to be added to the CSIT vpp-device-test jobs. Thanks, -daw- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14617): https://lists.fd.io/g/vpp-dev/message/14617 Mute This Topic: https://lists.fd.io/mt/60208819/1594641 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev%2bow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [pvi...@vinciconsulting.com<mailto:pvi...@vinciconsulting.com>] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14618): https://lists.fd.io/g/vpp-dev/message/14618 Mute This Topic: https://lists.fd.io/mt/60208819/1594641 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev%2bow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [pvi...@vinciconsulting.com<mailto:pvi...@vinciconsulting.com>] -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14655): https://lists.fd.io/g/vpp-dev/message/14655 Mute This Topic: https://lists.fd.io/mt/60208819/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
