Status update:
Florin fixed 'make checkstyle' with [1] (Thanks Florin! :)
Ed Kern has added 'make install-dep' to the checkstyle verify build
executors.
The revert of my ci-management patch [2] will be abandoned.
Florin's patch will be reverted once the new build executors are
available and verified that yamllint is available.
Sorry for the bog-up.
Thanks,
-daw-
[1] https://gerrit.fd.io/r/c/vpp/+/23391
[2] https://gerrit.fd.io/r/c/ci-management/+/23410
On 11/13/2019 8:58 AM, Dave Wallace via Lists.Fd.Io wrote:
Dave,
My bad. I had Vanessa merge a patch to ci-management [0] which I
tested locally, but forgot that the build executors don't run 'make
install-dep'.
Unfortunately the ci-management verify jobs don't actually run any of
the CI jobs to ensure that the system still works with the patch being
submitted...
I'm in the process of reverting the patch until the build executors
can be upgraded.
Thanks,
-daw-
[0] https://gerrit.fd.io/r/c/ci-management/+/23364
On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote:
I wonder where “yamllint” went? Multiple patches affected...
07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
07:28:24 HEAD detached at dce8b380a
07:28:24 nothing to commit, working tree clean
07:28:24
*******************************************************************
07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED
07:28:24
*******************************************************************
07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src
07:28:24 make: yamllint: Command not found
07:28:24 Makefile:561: recipe for target 'checkstyle' failed
07:28:24 make: *** [checkstyle] Error 127
07:28:24 Build step 'Execute shell' marked build as failure
FWIW... Dave
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14579):https://lists.fd.io/g/vpp-dev/message/14579
Mute This Topic:https://lists.fd.io/mt/55791974/675079
Group Owner:vpp-dev+ow...@lists.fd.io
Unsubscribe:https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583
Mute This Topic: https://lists.fd.io/mt/55791974/675079
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#14589): https://lists.fd.io/g/vpp-dev/message/14589
Mute This Topic: https://lists.fd.io/mt/55791974/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-