If next version of Python adds a new reserved keyword, it will "break" clients using PAPI in that version
(for calls using that keyword as argument name) anyway. The main downside is that our current checks only look at locally installed Python. So [3] got +1 just because verify jobs use Python 2 and not 3. Vratko. [3] https://gerrit.fd.io/r/c/vpp/+/21371 ________________________________ From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> on behalf of Florin Coras <fcoras.li...@gmail.com> Sent: Wednesday, August 21, 2019 17:47 To: Damjan Marion Cc: vpp-dev; Yu, Ping; Ole Troan (otroan) Subject: Re: [vpp-dev] ValueError: Fieldname 'async' is a python keyword and is not accessible via the python API On Aug 21, 2019, at 8:32 AM, Damjan Marion <dmar...@me.com<mailto:dmar...@me.com>> wrote: On 21 Aug 2019, at 17:15, Florin Coras <fcoras.li...@gmail.com<mailto:fcoras.li...@gmail.com>> wrote: Interesting. Want to push a patch to change async_enable or something like that here [1]? Or I can do that. Florin [1] https://git.fd.io/vpp/diff/src/plugins/tlsopenssl/tls_openssl.api?id=be4d1aa On Aug 21, 2019, at 7:41 AM, Damjan Marion via Lists.Fd.Io <dmarion=me....@lists.fd.io<mailto:dmarion=me....@lists.fd.io>> wrote: May be due to the fact that I use newer ubuntu version, but i'm not able to build VPP on master. This is error message I get: [1283/1678] Generating API header /home/damarion/cisco/vpp8/bui...build-vpp_debug-native/vpp/plugins/tlsopenssl/tls_openssl.api.h FAILED: plugins/tlsopenssl/tls_openssl.api.h cd /home/damarion/cisco/vpp8/build-root/build-vpp_debug-native/vpp/plugins/tlsopenssl && mkdir -p /home/damarion/cisco/vpp8/build-root/build-vpp_debug-native/vpp/plugins/tlsopenssl && /home/damarion/cisco/vpp8/src/tools/vppapigen/vppapigen --includedir /home/damarion/cisco/vpp8/src --input /home/damarion/cisco/vpp8/src/plugins/tlsopenssl/tls_openssl.api --output /home/damarion/cisco/vpp8/build-root/build-vpp_debug-native/vpp/plugins/tlsopenssl/tls_openssl.api.h ValueError: Fieldname 'async' is a python keyword and is not accessible via the python API. And looks like reverting [1] helps.... [1] https://git.fd.io/vpp/commit/?id=be4d1aa It sounds to me like right solution to the problem is to avoid python keyword-related constrains in API msg fields. Next time they may add new keyword and break existing API definitions.... Agreed. I suspect the issue is that we pass those fields as named params in python apis, but Ole should know the actual answer. Florin
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13802): https://lists.fd.io/g/vpp-dev/message/13802 Mute This Topic: https://lists.fd.io/mt/32978936/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
