Re: [vpp-dev] VPP 19.04:: 14 bytes extra Overhead on memif, from master to slave direction

[Mrityunjay Kumar]

Hi Damjan Marion

I have small query as below. let me know if I am missing some things


commit cef1db9c13f57a1fc49c9e500adffafa0b9ca728
Author: Damjan Marion <damar...@cisco.com>
Date:   Wed Mar 28 18:27:38 2018 +0200

    memif: zero copy slave

    Change-Id: I65306fb1f8e39221dd1d8c00737a7fb1c0129ba8
    Signed-off-by: Damjan Marion <damar...@cisco.com>



Regards

Mrityunjay

________________________________
From: Mrityunjay Kumar
Sent: Wednesday, July 31, 2019 2:28:54 PM
To: i...@fd.io <i...@fd.io>; vpp-dev@lists.fd.io <vpp-dev@lists.fd.io>
Cc: kmrityunj...@altiostar.com <kmrityunj...@altiostar.com>
Subject: VPP 19.04:: 14 bytes extra Overhead on memif, from master to slave 
direction


Hi

I have observed that, there are 14 bytes extra overhead added in packet in case 
of route from memif [master, mode: IP] to memif [salve, Mode:IP].

This 14 bytes overhead has been added by salve after receiving the packet from 
mem interface.



To fix this issue, I have added/modified the code as below.



VPP-19.04

diff --git a/src/plugins/memif/node.c b/src/plugins/memif/node.c

index 07ce76d..dabf083 100644

--- a/src/plugins/memif/node.c

+++ b/src/plugins/memif/node.c

@@ -595,7 +595,8 @@ memif_device_input_zc_inline (vlib_main_t * vm, 
vlib_node_runtime_t * node,

       d0 = &ring->desc[s0];

       hb = b0 = vlib_get_buffer (vm, bi0);

       b0->current_data = start_offset;

-      b0->current_length = start_offset + d0->length;

+      //b0->current_length = start_offset + d0->length;

+      b0->current_length =  d0->length;

       n_rx_bytes += d0->length;



       if (0 && memif_desc_is_invalid (mif, d0, buffer_length))

@@ -618,7 +619,8 @@ memif_device_input_zc_inline (vlib_main_t * vm, 
vlib_node_runtime_t * node,

          /* current buffer */

          b0 = vlib_get_buffer (vm, bi0);

          b0->current_data = start_offset;

-         b0->current_length = start_offset + d0->length;

+         //b0->current_length = start_offset + d0->length;

+      b0->current_length =  d0->length;

          hb->total_length_not_including_first_buffer += d0->length;

          n_rx_bytes += d0->length;





Please correct me if I am missing some configuration.



Regards

Mrityunjay


=====================================================
Please refer to https://northamerica.altran.com/email-disclaimer
for important disclosures regarding this electronic communication.
=====================================================

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13630): https://lists.fd.io/g/vpp-dev/message/13630
Mute This Topic: https://lists.fd.io/mt/32665787/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-