My 5 kopecks: good idea to add this setting, but keep it commented out by default, and add a comment to the service config file “# uncomment the next line to enable coredump” as well as to docs or other prominent place where folks frantically searching on how to enable coredump would find it...
Also, there is a setting in startup.conf that talks about the core file size - do you know how do the two interact ? (I never checked, just remember seeing it). --a > On 4 Jul 2019, at 11:52, Benoit Ganne (bganne) via Lists.Fd.Io > <bganne=cisco....@lists.fd.io> wrote: > > Hi all, > > I'd like to get some opinion on this change: https://gerrit.fd.io/r/c/20499/ > > Right now, if you install VPP from packages and run it through systemd, it > can be quite convoluted to get coredumps: > - /proc/sys/kernel/core_pattern must be correctly set > - distro coredump handler (eg. Ubuntu Apport or system-coredump) must be > correctly configured > - core dumps must be enabled on VPP command line > - core dumps size limit must be correctly configured when starting it through > systemd > The last one can be especially tricky for users as it is obviously not > governed by 'ulimit -c' in user shell and /etc/security/limits.* can be > superseded by systemd conf. > So, I propose to set ulimit in VPP system unit file, so that it becomes > slightly easier to enable coredump for VPP. > The drawback could be to generate a lot of huge coredumps and fill the disk > w/o the user noticing it, but I think most distro diable it system-wide > anyway by default. > > Any thought? > > ben > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#13438): https://lists.fd.io/g/vpp-dev/message/13438 > Mute This Topic: https://lists.fd.io/mt/32306587/675608 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [ayour...@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13439): https://lists.fd.io/g/vpp-dev/message/13439 Mute This Topic: https://lists.fd.io/mt/32306587/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
