Hi Chore, Thank you for the patch, I have merged it.
/neale De : <vpp-dev@lists.fd.io> au nom de emma sdi <s3m2e1.6s...@gmail.com> Date : mercredi 26 juin 2019 à 07:06 À : Damjan Marion <dmar...@me.com> Cc : vpp-dev <vpp-dev@lists.fd.io> Objet : Re: [vpp-dev] NAT dose not exist in MAINTAINERS file Hi Dear VPP Would you please take a look at https://gerrit.fd.io/r/#/c/20325/ and merge this commit. previously Damjan told me to amend my commit and add nat in MAINTAINERS file but I did it in another commit independently. Thanks Chore On Tue, Jun 25, 2019 at 5:01 PM Damjan Marion <dmar...@me.com<mailto:dmar...@me.com>> wrote: Dear Emma, This is exact reason why we introduced commit checks. It will help us to keep MAINTAINERS file up to date, without this check nobody will notice that nat is missing there. Ole is our nat guy, please amend your patch with MAINTAINERS update and add Ole as maintainer... — Damjan > On Jun 25, 2019, at 2:20 PM, emma sdi > <s3m2e1.6s...@gmail.com<mailto:s3m2e1.6s...@gmail.com>> wrote: > > Hi Dear VPP > > Why NAT dose not exist in MAINTAINERS file?! as you know, during build phase, > commit message subject is inspected inside MAINTAINERS file. so how could be > possible a succeeded commit in NAT plug-in? > > Thanks > Chore > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#13362): https://lists.fd.io/g/vpp-dev/message/13362 > Mute This Topic: https://lists.fd.io/mt/32202722/675642 > Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev%2bow...@lists.fd.io> > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub > [dmar...@me.com<mailto:dmar...@me.com>] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13378): https://lists.fd.io/g/vpp-dev/message/13378 Mute This Topic: https://lists.fd.io/mt/32202722/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
