Can you try to replace: format_vlib_pci_vpd, d->vpd_r, 0);
with format_vlib_pci_vpd, d->vpd_r, NULL); in show_pci_fn() - src/vlib/pci/pci.c > On 24 May 2019, at 07:45, siddarth rai <sid...@gmail.com> wrote: > > I believe you can see this issue with any NIC. (Invalid value being returned > from var_arg). It does not not always crash, but the value is always wrong. > > On Thu, May 23, 2019 at 6:58 PM Damjan Marion <dmar...@me.com > <mailto:dmar...@me.com>> wrote: > > > > On 23 May 2019, at 15:21, siddarth rai <sid...@gmail.com > > <mailto:sid...@gmail.com>> wrote: > > > > Hello, > > > > I am using an older version of VPP(18.01) but I checked the code of 19.04 > > and I couldn't find any change in problematic area. > > > > I sometimes get a crash with "Show PCI" command. > > > > From the core, it seems to be crashing here : > > > > "format_vlib_pci_vpd ( > > s=0x2ad325f2cb58 "0000:02:00.0 0 14e4:1657 5.0 GT/s x2 tg3", ' ' > > <repeats 13 times>, "HP Ethernet 1Gb 4-port 331i Adapter", args=<optimized > > out>)" > > > > I checked this function and it seems that a particular pointer variable > > (u8* id) always ends up getting an invalid value - "0x3000000000 <Address > > 0x3000000000 out of bounds>" > > Further down in this function, we try to access this pointer and that > > sometimes causes the VPP to crash. > > > > Could it be that the "va_arg" call to get this "id" is returning something > > invalid? > > > > Can someone please help me with this ? > > > > Attaching the full stack trace as well. > > Probably bug in PCI VPD parser. Hard to debug blindly, without having access > to problematic NIC. > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#13136): https://lists.fd.io/g/vpp-dev/message/13136 > Mute This Topic: https://lists.fd.io/mt/31730875/675642 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13138): https://lists.fd.io/g/vpp-dev/message/13138 Mute This Topic: https://lists.fd.io/mt/31730875/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
