On 4/10/2019 5:22 PM, Dave Wallace via Lists.Fd.Io wrote:


On 4/10/2019 5:11 PM, Damjan Marion wrote:

On 10 Apr 2019, at 22:52, Dave Wallace <dwallac...@gmail.com> wrote:



On 4/10/2019 4:43 PM, Damjan Marion wrote:

On 10 Apr 2019, at 21:12, Dave Wallace <dwallac...@gmail.com> wrote:

Folks,

The VPP master branch is now closed for the branch pull of stable/1904.

Please do NOT merge any patches until I give the all clear once the branch pull has been completed and verified.

I will send an update when master is re-open for business.

Thanks in advance for your cooperation!
-daw-
"Your Friendly VPP 19.04 Release Manager”
I don't think merging patches will do any harm, stable branch creation is just using reference to specific commit-id, and that one doesn’t need to be latest one on master.
Not unless one manages to bog up the branch pull / label process, which I managed to do the on the first release I managed.  It was much easier to clean up the mess without new patches on master.

And since I tend to be a bit pedantic, it annoys me that there are XX.YY-rc1 tags and XX.ZZ-rc0 tags which aren't on the same patch due to merges on master during the branch pull process.
They shouldn't be, both tags should be put on 2 different patches which share same parent which is also branching point.

i.e.

----a---b----c----- master
            \----d----- stable/xx.yy

c should get xx.(yy+3)-rc0 tag
d shoud get xx.yy-rc1 tag
b is branching point....
Good point.  Since we no longer merge a JVPP version update patch to master, the current process doesn't produce the desired result.

As it stands, 'b' has the label "v19.08-rc0" and 'c' has the label "v19.04-rc1".  I'll delete the tab v19.08-rc0 and put it on the 1st patch merged to master.

Sorry,  I made a typo in the above sentence,  'd' is the patch with 'v19.04-rc1' so it is correct.
And will update the process on the wiki appropriately.

Thanks for the clarification!
-daw-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12755): https://lists.fd.io/g/vpp-dev/message/12755
Mute This Topic: https://lists.fd.io/mt/31022623/675079
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dwallac...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12756): https://lists.fd.io/g/vpp-dev/message/12756
Mute This Topic: https://lists.fd.io/mt/31022623/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to