On 04/01/2019 05:44 AM, Damjan Marion (damarion) wrote:
On 31 Mar 2019, at 05:39, Thomas F Herbert <therb...@redhat.com
<mailto:therb...@redhat.com>> wrote:
Damjan,
I attempted to fix a problem with use of cmake breaking CentOS builds
with the patch introduced with the new rdma-core and quicly driver.
I had this fixed with patch https://gerrit.fd.io/r/#/c/18600/ but it
wouldn't rebase after another change with quicly.
The patch no longer applies because the quickly.mk in gone and the
problem appears after a patch of some upstream code. Could you please
take a look at this:
Submodule path 'deps/picotls': checked out
'70cd2a60125729f6d6c32c2ace36403b2b6168e6'
--- patching quicly f25b70d37f8974af9cc48a4a565d13a9cdc5fd75
Applying patch: 0001-cmake-install.patch
patching file CMakeLists.txt
patching file deps/picotls/CMakeLists.txt
--- configuring quicly f25b70d37f8974af9cc48a4a565d13a9cdc5fd75 -
log:
/home/therbert/vpp/build-root/rpmbuild/vpp-19.04/build-root/build-vpp-native/external/quicly.config.log
--- building quicly f25b70d37f8974af9cc48a4a565d13a9cdc5fd75 - log:
/home/therbert/vpp/build-root/rpmbuild/vpp-19.04/build-root/build-vpp-native/external/quicly.build.log
/bin/bash: cmake: command not found
make[5]: *** [packages/quicly.mk:43:
/home/therbert/vpp/build-root/rpmbuild/vpp-19.04/build-root/build-vpp-native/external/.quicly.build.ok]
Error 127
Yes, i reverted quicly packaging changes as they need a bit of
polishing so you need to rebase your patch.
My patch is re-based but is this reversion you speak of merged yet? I
don't see it on master?
--
Damjan
--
*Thomas F Herbert*
NFV and Fast Data Planes
Networking Group Office of the CTO
*Red Hat*
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12683): https://lists.fd.io/g/vpp-dev/message/12683
Mute This Topic: https://lists.fd.io/mt/30840381/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
