I commented out the offending parts and now PPPoE is working fine.
diff --git a/src/vnet/ethernet/node.c b/src/vnet/ethernet/node.c
index 53d5b4eb0..7c5f673e0 100755
--- a/src/vnet/ethernet/node.c
+++ b/src/vnet/ethernet/node.c
@@ -429,14 +429,14 @@ ethernet_input_inline (vlib_main_t * vm,
}
else
{
+ /*if (!ethernet_address_cast (e0->dst_address) &&
(hi->hw_address != 0) &&
!eth_mac_equal ((u8 *) e0, hi->hw_address))
error0 = ETHERNET_ERROR_L3_MAC_MISMATCH;
if (!ethernet_address_cast (e1->dst_address) &&
(hi->hw_address != 0) &&
!eth_mac_equal ((u8 *) e1, hi->hw_address))
+ error1 = ETHERNET_ERROR_L3_MAC_MISMATCH;*/
vlib_buffer_advance (b0, sizeof (ethernet_header_t));
determine_next_node (em, variant, 0, type0, b0,
&error0, &next0);
@@ -653,10 +653,10 @@ ethernet_input_inline (vlib_main_t * vm,
}
else
{
+ /*if (!ethernet_address_cast (e0->dst_address) &&
(hi->hw_address != 0) &&
!eth_mac_equal ((u8 *) e0, hi->hw_address))
+ error0 = ETHERNET_ERROR_L3_MAC_MISMATCH;*/
vlib_buffer_advance (b0, sizeof (ethernet_header_t));
determine_next_node (em, variant, 0, type0, b0,
&error0, &next0);
I am sure this is not a patch which will be accepted upstream. I am
not sure how to _correctly_ fix this, so that it will be accepted by
upstream. If some pointers are given I can submit a patch to get PPPoE
working correctly again in VPP.
Thanks and Regards,
Raj
On Tue, Mar 19, 2019 at 1:09 PM Raj via Lists.Fd.Io
<rajlistuser=gmail....@lists.fd.io> wrote:
>
> Another approach that can be used is to send all PPP/PPPoE control
> packets encapsulated in NSH, and Control plane can process it and
> return the packets to VPP which will decapsulate the NSH headers and
> pass the packets on to PPPoE client.
>
> Thanks and Regards,
>
> Raj
>
> On Mon, Mar 18, 2019 at 7:44 PM Raj via Lists.Fd.Io
> <rajlistuser=gmail....@lists.fd.io> wrote:
> >
> > On Thu, Dec 20, 2018 at 6:17 AM Ni, Hongjun <hongjun...@intel.com> wrote:
> >
> > > For the issue you mentioned, Alp Arslan in the To list will submit a
> > > patch to fix it.
> >
> > I can take a stab at this and prepare a patch to get PPPoE working
> > again in VPP. I understand that this error happens because VPP will
> > only allow packets whose destination MAC is the same as the interface
> > MAC or bcast/mcast MAC. How should I go about fixing this? Would
> > turning off off this check for TAP interface work? Any better way to
> > achieve this result?
> >
> > Thanks and Regards,
> >
> > Raj
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#12588): https://lists.fd.io/g/vpp-dev/message/12588
> Mute This Topic: https://lists.fd.io/mt/28791570/157026
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [rajlistu...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12593): https://lists.fd.io/g/vpp-dev/message/12593
Mute This Topic: https://lists.fd.io/mt/28791570/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
