Folks,
Is there a valid use for duplicate nodes in the node graph?
Specifically, if I type this command three times:
vpp# set interface ip vxlan-bypass TenGigabitEthernet6/0/0
vpp# set interface ip vxlan-bypass TenGigabitEthernet6/0/0
vpp# set interface ip vxlan-bypass TenGigabitEthernet6/0/0
I end up with duplicate ip4-vxlan-nodes:
vpp# show interface features TenGigabitEthernet6/0/0
[ ...]
ip4-unicast:
ip4-not-enabled
ip4-vxlan-bypass
ip4-vxlan-bypass
ip4-vxlan-bypass
In this case, I don't think it makes sense, and I think we should detect
the presence of the node and disallow multiple additions.
If that is true for this case, but NOT true for other cases, we might
entertain
a flag (per interface per family) in the
function vnet_int_vxlan_bypass_mode()
to record its addition and prevent subsequent re-additions.
On the other hand, if duplicate nodes is a Bad Thing for the whole graph,
perhaps the function vnet_feature_enable_disable() itself should be able
to detect and prevent duplicates?
Thoughts?
jdl
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#11787): https://lists.fd.io/g/vpp-dev/message/11787
Mute This Topic: https://lists.fd.io/mt/28873312/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
