On Mon, Dec 17, 2018 at 11:51 PM Marco Varlese <mvarl...@suse.de> wrote:
> Hi Brian, > > On Mon, 2018-12-17 at 20:19 -0800, Brian Dickson wrote: > > Hi, VPP folks, > > I am trying to add in support for a new card/driver. > > The info on the DPDK website says the drivers I have should work fine. > > Thus, the only issue is adding in the correct manufacturer/device IDs into > the init.c file: > > src/plugins/dpdk/device/init.c > > > I edit the file (one-line change), put it back into the .tar.xz file, put > it where it should be being picked up (in build-root or so I believe), and > it gets blown away. > > > It always seems to want to pull everything from git regardless of the > presence of the right tar.xz file in build-root, pointed to by the > vpp-latest symbolic link. > > > I am using "make pkg-rpm" as the command to rebuild things from the main > vpp source root (parent of build-root). > > > What am I doing wrong? > > > Where should I be rebuilding this? > > If it's something that small I would suggest to follow the same approach > used today: add a patch to the VPP repo to patch DPDK tarball after it has > been downloaded. > The problem (or so it seems to me) is that the thing needing patched is part of the vpp plugins, not dpdk's tarball itself. The patch stuff seems specific to stuff in external (e.g. dpdk), and I couldn't figure out how to do something similar to vpp itself. > See under "/build/external/patches/" there are various sub-folders for the > different DPDK versions. > The file build/external/packages.mk already takes care of navigating the > various directories to apply the patch files so it's a matter of having the > new patch in the directory as mentioned above. > Now, I am not sure whether your patch is already on its ways to DPDK > upstream but it would be really a good idea to do that. > No, it's not dpdk that needs the patch, it is vpp's plugins (specifically the plugin for dpdk), which needs the card support added. Specifically plugins/dpdk/device/init.c (That's where specific mfg:device combos are validated.) BTW, I think I did manage to build something that accepted the card, but there still seems to be something that dpdk itself doesn't like about the card/driver. Here's what I did, literally: "cd extras/rpm; make" - which builds a new set of *.rpm files and puts them in build-root, and then I did a "yum reinstall *.rpm" to those. I no longer get the "dpdk: Unsupported PCI device 0x1077:0x1634 found at PCI address 0000:65:00.1" messages. However, after starting up vpp, I get "kernel: qede 0000:65:00.0: Ending qede_remove successfully" (for both of the PCI devices). I might have to rebuild dpdk for the card, as well as the vpp plugin. The card in question is a Cavium (nee Qlogic, now Marvell) FastLinq 45000 series, with mfg:device of 0x1077:0x1634 The driver is qede: qede 65:00.00: Storm FW 8.37.5.0, Management FW 8.35.41.0 [MBI 8.35.21] [ens2f0] The dpdk site says this should be good for dpdk support. Any suggestions (e.g. dpdk version, plus build instructions for the vpp plugins change for dpdk) welcome. Thanks in advance, Brian > > What command should I use? > > Or what make target? > > In what directory? > > I suppose all the three questions above are answered in the 1st point. > > > Thanks in advance. > > > Brian > > Best, > Marco > > > P.S. I already spent a lot of time chasing a red herring. Does someone > want to explain to me the purpose of the "sed -e s/-/_/" in > extras/rpm/Makefile, full line: > > RELEASE=$(shell echo $(BASENAME) | cut -f3- -d- | sed -e s/-/_/g) > > > It seems really out of place, and leads to lots of difficulty in tracking > down the place where something that looks like "foo-bar-blech" becomes > "foo-bar_blech", for no obvious reason. > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > > View/Reply Online (#11641): > > https://lists.fd.io/g/vpp-dev/message/11641 > > > Mute This Topic: > > https://lists.fd.io/mt/28789545/675056 > > > Group Owner: > > vpp-dev+ow...@lists.fd.io > > > Unsubscribe: > > https://lists.fd.io/g/vpp-dev/unsub > > [ > > mvarl...@suse.de > > ] > > -=-=-=-=-=-=-=-=-=-=-=- > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11660): https://lists.fd.io/g/vpp-dev/message/11660 Mute This Topic: https://lists.fd.io/mt/28789545/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
