Stephen, Can you make this dependency optional? CMake detect presence of libuuid and then conditionally compile vmbus code?
In some cases that library might not be present, specially in some embedded cases... That will also allow us to merge that code immediately and later we can fix different distros. -- Damjan > On 7 Dec 2018, at 13:59, Stephen Hemminger <step...@networkplumber.org> wrote: > > The VMBus changes keep failing build on CentOs because of > missing install of new dependency (libuuid-devel). > > See: https://gerrit.fd.io/r/15311 > > The RPM_DEPENDS is updated in the Makefile, and it works on a local CentOs > 7.6 VM. > I suspect that the build CI doesn't do 'make install-dep' so it > doesn't correctly pickup the new dependency. > > P.S: VMBus support won't work yet on CentOS because the version > of uio_hv_generic in the RHEL/CentOS kernel is too old, but that > will get fixed. > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#11527): https://lists.fd.io/g/vpp-dev/message/11527 > Mute This Topic: https://lists.fd.io/mt/28668850/675642 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11548): https://lists.fd.io/g/vpp-dev/message/11548 Mute This Topic: https://lists.fd.io/mt/28668850/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
