Hi Ole,

I tried it and it does solve the issue, thanks!

Sirshak, does it work for you too?

Juraj

From: Ole Troan [mailto:otr...@employees.org]
Sent: Wednesday, November 28, 2018 9:25 AM
To: Sirshak Das <sirshak....@arm.com>
Cc: Juraj Linkeš <juraj.lin...@pantheon.tech>; vpp-dev@lists.fd.io; Honnappa 
Nagarahalli <honnappa.nagaraha...@arm.com>; Lijian Zhang (Arm Technology China) 
<lijian.zh...@arm.com>
Subject: Re: [vpp-dev] Build failing on AArch64

Sirshak,

Can you try adding:

DEPENDS api_headers

Inside
add_vpp_executable(vpp_api_test ENABLE_EXPORTS

in src/vat/CMakeLists.txt

Cheers,
Ole

> On 28 Nov 2018, at 06:32, Sirshak Das 
> <sirshak....@arm.com<mailto:sirshak....@arm.com>> wrote:
>
> It takes 3 iterations to get to a proper build:
>
> First Iteration:
>
> FAILED: vat/CMakeFiles/vpp_api_test.dir/types.c.o
> ccache /usr/lib/ccache/cc -DHAVE_MEMFD_CREATE -Dvpp_api_test_EXPORTS 
> -I/home/sirdas/code/commitc/vpp/src -I. -Iinclude -march=armv8-a+crc -g -O2 
> -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
> -Wno-address-of-packed-member -pthread -MD -MT 
> vat/CMakeFiles/vpp_api_test.dir/types.c.o -MF 
> vat/CMakeFiles/vpp_api_test.dir/types.c.o.d -o 
> vat/CMakeFiles/vpp_api_test.dir/types.c.o   -c 
> /home/sirdas/code/commitc/vpp/src/vat/types.c
> In file included from 
> /home/sirdas/code/commitc/vpp/src/vpp/api/vpe_all_api_h.h:25,
>                from /home/sirdas/code/commitc/vpp/src/vpp/api/types.h:20,
>                from /home/sirdas/code/commitc/vpp/src/vat/types.c:19:
> /home/sirdas/code/commitc/vpp/src/vnet/vnet_all_api_h.h:32:10: fatal error: 
> vnet/bonding/bond.api.h: No such file or directory
> #include <vnet/bonding/bond.api.h>
>         ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Second Iteration:
>
> FAILED: vat/CMakeFiles/vpp_api_test.dir/types.c.o
> ccache /usr/lib/ccache/cc -DHAVE_MEMFD_CREATE -Dvpp_api_test_EXPORTS 
> -I/home/sirdas/code/commitc/vpp/src -I. -Iinclude -march=armv8-a+crc -g -O2 
> -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
> -Wno-address-of-packed-member -pthread -MD -MT 
> vat/CMakeFiles/vpp_api_test.dir/types.c.o -MF 
> vat/CMakeFiles/vpp_api_test.dir/types.c.o.d -o 
> vat/CMakeFiles/vpp_api_test.dir/types.c.o   -c 
> /home/sirdas/code/commitc/vpp/src/vat/types.c
> In file included from /home/sirdas/code/commitc/vpp/src/vpp/api/types.h:20,
>                from /home/sirdas/code/commitc/vpp/src/vat/types.c:19:
> /home/sirdas/code/commitc/vpp/src/vpp/api/vpe_all_api_h.h:32:10: fatal error: 
> vpp/stats/stats.api.h: No such file or directory
> #include <vpp/stats/stats.api.h>
>         ^~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> [142/1163] Building C object vat/CMakeFiles/vpp_api_test.dir/api_format.c.o^C
> ninja: build stopped: interrupted by user.
> Makefile:691: recipe for target 'vpp-build' failed
> make[1]: *** [vpp-build] Interrupt
> Makefile:366: recipe for target 'build-release' failed
> make: *** [build-release] Interrupt
>
> Had to kill as it was stuck.
>
> Third Interation:
>
> Finally it got built properly.
>
> This is a manageble error for dev purposes but will give lot false
> negatives for CI.
> Anyone familiar with VAT please help.
>
>
> Thank you
> Sirshak Das
>
> Ole Troan writes:
>
>> Juraj,
>>
>> Seems like a dependency problem. VAT depends on a generated file that hasn’t 
>> been generated yet.
>>
>> Ole
>>
>>> On 27 Nov 2018, at 18:04, Juraj Linkeš 
>>> <juraj.lin...@pantheon.tech<mailto:juraj.lin...@pantheon.tech>> wrote:
>>>
>>> Hi Ole,
>>>
>>>              I'm hitting the same issue.
>>>
>>>              Running the build with V=2 doesn't actually produce more 
>>> output.
>>>
>>> Which means my logs are the same as Sirshak's. But in any case I attached 
>>> the output from a run with V=2.
>>>
>>> I can provide other info if there's more you need - or you can try 
>>> accessing one of our ThunderX's in the FD.io lab if you have access.
>>>
>>> Thanks,
>>> Juraj
>>>
>>> From: Ole Troan [mailto:otr...@employees.org]
>>> Sent: Tuesday, November 27, 2018 5:43 PM
>>> To: Juraj Linkeš 
>>> <juraj.lin...@pantheon.tech<mailto:juraj.lin...@pantheon.tech>>
>>> Cc: Sirshak Das <sirshak....@arm.com<mailto:sirshak....@arm.com>>; 
>>> vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>; Honnappa Nagarahalli 
>>> <honnappa.nagaraha...@arm.com<mailto:honnappa.nagaraha...@arm.com>>; Lijian 
>>> Zhang (Arm Technology China) 
>>> <lijian.zh...@arm.com<mailto:lijian.zh...@arm.com>>
>>> Subject: Re: [vpp-dev] Build failing on AArch64
>>>
>>> Juraj,
>>>
>>> Without a make log this is just a guessing game.
>>>
>>> Cheers
>>> Ole
>>>
>>> On 27 Nov 2018, at 17:34, Juraj Linkeš 
>>> <juraj.lin...@pantheon.tech<mailto:juraj.lin...@pantheon.tech>> wrote:
>>>
>>> Hi Sirshak and Ole,
>>>
>>> I'm hitting the same issue. The build fails on a clean repository, but the 
>>> subsequent build works fine, which is fine for local builds, but still 
>>> needs to be fixed.
>>>
>>> Running the build with V=2 doesn't actually produce more output. There one 
>>> more bit of information I can provide - this behavior is present on 
>>> Ubuntu1804 (4.15.0-38-generic), but builds on Ubuntu1604 
>>> (4.4.0-138-generic) work right away, which explains why CI didn't catch it.
>>>
>>> This is the patch that introduced the issue: 
>>> https://gerrit.fd.io/r/#/c/16109/
>>>
>>> Juraj
>>>
>>> From: Ole Troan [mailto:otr...@employees.org]
>>> Sent: Monday, November 26, 2018 9:26 AM
>>> To: Sirshak Das <sirshak....@arm.com<mailto:sirshak....@arm.com>>
>>> Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>; Honnappa Nagarahalli 
>>> <honnappa.nagaraha...@arm.com<mailto:honnappa.nagaraha...@arm.com>>; Juraj 
>>> Linkeš <juraj.lin...@pantheon.tech<mailto:juraj.lin...@pantheon.tech>>; 
>>> Lijian Zhang (Arm Technology China) 
>>> <lijian.zh...@arm.com<mailto:lijian.zh...@arm.com>>
>>> Subject: Re: [vpp-dev] Build failing on AArch64
>>>
>>> Sirshak,
>>>
>>> Can you touch one of the .api files and rebuild with V=2 and show the 
>>> output of that?
>>> It might be that vppapigen fails for some reason (or try to run it manually 
>>> and see).
>>>
>>> Ole
>>>
>>>> On 26 Nov 2018, at 06:48, Sirshak Das 
>>>> <sirshak....@arm.com<mailto:sirshak....@arm.com>> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> I am currently facing these build failures in master on AArch64.
>>>>
>>>> [38/1160] Building C object vat/CMakeFiles/vpp_api_test.dir/types.c.o
>>>> FAILED: vat/CMakeFiles/vpp_api_test.dir/types.c.o
>>>> ccache /usr/lib/ccache/cc -DHAVE_MEMFD_CREATE -Dvpp_api_test_EXPORTS 
>>>> -I/home/sirdas/code/commita/vpp/src -I. -Iinclude -march=armv8-a+crc -g 
>>>> -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
>>>> -Wno-address-of-packed-member -pthread -MD -MT 
>>>> vat/CMakeFiles/vpp_api_test.dir/types.c.o -MF 
>>>> vat/CMakeFiles/vpp_api_test.dir/types.c.o.d -o 
>>>> vat/CMakeFiles/vpp_api_test.dir/types.c.o   -c 
>>>> /home/sirdas/code/commita/vpp/src/vat/types.c
>>>> In file included from 
>>>> /home/sirdas/code/commita/vpp/src/vpp/api/vpe_all_api_h.h:25,
>>>>               from /home/sirdas/code/commita/vpp/src/vpp/api/types.h:20,
>>>>               from /home/sirdas/code/commita/vpp/src/vat/types.c:19:
>>>> /home/sirdas/code/commita/vpp/src/vnet/vnet_all_api_h.h:33:10: fatal 
>>>> error: vnet/devices/af_packet/af_packet.api.h: No such file or directory
>>>> #include <vnet/devices/af_packet/af_packet.api.h>
>>>>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> compilation terminated.
>>>> [85/1160] Building C object 
>>>> vnet/CMakeFiles/vnet_cortexa72.dir/ethernet/node.c.o
>>>> ninja: build stopped: subcommand failed.
>>>> Makefile:691: recipe for target 'vpp-build' failed
>>>> make[1]: *** [vpp-build] Error 1
>>>> make[1]: Leaving directory '/home/sirdas/code/commita/vpp/build-root'
>>>> Makefile:366: recipe for target 'build-release' failed
>>>> make: *** [build-release] Error 2
>>>>
>>>> [114/1310] Building C object vat/CMakeFiles/vpp_api_test.dir/types.c.o
>>>> FAILED: vat/CMakeFiles/vpp_api_test.dir/types.c.o
>>>> ccache /usr/lib/ccache/cc -DHAVE_MEMFD_CREATE -Dvpp_api_test_EXPORTS 
>>>> -I/home/sirdas/code/commitb/vpp/src -I. -Iinclude -march=armv8-a+crc -g 
>>>> -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror   
>>>> -Wno-address-of-packed-member -pthread -MD -MT 
>>>> vat/CMakeFiles/vpp_api_test.dir/types.c.o -MF 
>>>> vat/CMakeFiles/vpp_api_test.dir/types.c.o.d -o 
>>>> vat/CMakeFiles/vpp_api_test.dir/types.c.o   -c 
>>>> /home/sirdas/code/commitb/vpp/src/vat/types.c
>>>> In file included from 
>>>> /home/sirdas/code/commitb/vpp/src/vpp/api/vpe_all_api_h.h:25,
>>>>               from /home/sirdas/code/commitb/vpp/src/vpp/api/types.h:20,
>>>>               from /home/sirdas/code/commitb/vpp/src/vat/types.c:19:
>>>> /home/sirdas/code/commitb/vpp/src/vnet/vnet_all_api_h.h:32:10: fatal 
>>>> error: vnet/bonding/bond.api.h: No such file or directory
>>>> #include <vnet/bonding/bond.api.h>
>>>>        ^~~~~~~~~~~~~~~~~~~~~~~~~
>>>> compilation terminated.
>>>> [161/1310] Building C object 
>>>> vnet/CMakeFiles/vnet_thunderx2t99.dir/ethernet/node.c.o
>>>> ninja: build stopped: subcommand failed.
>>>> Makefile:691: recipe for target 'vpp-build' failed
>>>> make[1]: *** [vpp-build] Error 1
>>>> make[1]: Leaving directory '/home/sirdas/code/commitb/vpp/build-root'
>>>> Makefile:366: recipe for target 'build-release' failed
>>>> make: *** [build-release] Error 2
>>>>
>>>>
>>>> Its all someway or the other related to *.api files and genereated
>>>> header files.
>>>>
>>>> I am not able to isolate any particular commit that did this.
>>>>
>>>> Does anybody know if anything changed off the top of their head ?
>>>>
>>>> Thank you
>>>> Sirshak Das
>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>> Links: You receive all messages sent to this group.
>>>>
>>>> View/Reply Online (#11400): https://lists.fd.io/g/vpp-dev/message/11400
>>>> Mute This Topic: https://lists.fd.io/mt/28318534/675193
>>>> Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
>>>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [otr...@employees.org]
>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#11404): https://lists.fd.io/g/vpp-dev/message/11404
>>> Mute This Topic: https://lists.fd.io/mt/28318534/899915
>>> Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
>>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
>>> [juraj.lin...@pantheon.tech]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> <make.txt>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#11435): https://lists.fd.io/g/vpp-dev/message/11435
>>> Mute This Topic: https://lists.fd.io/mt/28318534/675193
>>> Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
>>> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [otr...@employees.org]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11442): https://lists.fd.io/g/vpp-dev/message/11442
Mute This Topic: https://lists.fd.io/mt/28318534/899915
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [juraj.lin...@pantheon.tech]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11462): https://lists.fd.io/g/vpp-dev/message/11462
Mute This Topic: https://lists.fd.io/mt/28318534/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to