> On 16 Nov 2018, at 02:02, Stephen Hemminger <step...@networkplumber.org> > wrote: > > I just discovered the clang-format file and noticed that Linux kernel used > the ForEachMacros option to format for() wrappers. > > VPP seems to be riddled with INDENT-OFF when it does vector loops. (2123 > times!) > Has anyone looked into replacing these with ForEachMacros?
Yes, i looked into it, and found 2 big issues: - clang-format gnu mode produces different result than gnu indent so we will need to reformat whole repo - clang-format doesn't produce consistent output between 2 versions, which means mess every time we move to newer distro I looked into it 1+ yr ago, so things maybe changed, if yes we can reevaluate....
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11282): https://lists.fd.io/g/vpp-dev/message/11282 Mute This Topic: https://lists.fd.io/mt/28156993/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
