Hello, Just wanted to bring attention to what I believe are two issues with the tx_burst_vector_internal() function in src/plugins/dpdk/device/device.c
1) The first concerns this if statement: if (PREDICT_FALSE (n_sent < 0)) Where n_sent is set by: n_sent = rte_ring_sp_enqueue_burst(...); or n_sent = rte_eth_tx_burst(...); Both of these dpdk functions return unsigned integers (numbers of packets) http://doc.dpdk.org/api/rte__ring_8h.html#af373df0f0f5ea334fd7d2ae90b451d3f http://doc.dpdk.org/api/rte__ethdev_8h.html#a83e56cabbd31637efd648e3fc010392b 2) The second item is about while loop while (n_sent && n_left && (n_retry > 0)); n_retry is initialized to 16, but never decremented. Thanks, Jeff
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10838): https://lists.fd.io/g/vpp-dev/message/10838 Mute This Topic: https://lists.fd.io/mt/27371135/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
