Yes, this causes test-debug target to take the old way (not cmake). This, though, seems a bit counter-intuitive. Shouldn't setting the value to "no" cause the build process to not use cmake?
On Mon, 2018-08-20 at 12:15 +0200, Damjan Marion wrote: > > > > On 20 Aug 2018, at 11:55, Klement Sekera <ksek...@cisco.com> wrote: > > > > Hi Damjan, > > > > it seems that the test-debug target is broken with the patch. The > > build > > process triggered by test-debug target jumps on the cmake train, > > but > > that train doesn't bring in the APIGEN and other stuff (e.g. > > libvppapiclient.so). > Does this help? > diff --git a/Makefile b/Makefile > index 09a31083..f9fd95ff 100644 > --- a/Makefile > +++ b/Makefile > @@ -21,7 +21,7 @@ STARTUP_DIR?=$(PWD) > MACHINE=$(shell uname -m) > SUDO?=sudo > > -ifeq ($(findstring $(MAKECMDGOALS),verify pkg-deb pkg-rpm test),) > +ifeq ($(findstring $(MAKECMDGOALS),verify pkg-deb pkg-rpm test test- > debug),) > export vpp_uses_cmake?=yes > endif > > > > > > > I don't see vpp-api mentioned in src/CMakeLists.txt. Should it be > > mentioned? > It waits for volunteer to take care for vpp-api :) > > > > > > > Thanks, > > Klement > > > > On Sat, 2018-08-18 at 12:38 +0200, Damjan Marion via Lists.Fd.Io > > wrote: > > > > > > Dear all, > > > > > > Yesterday we merged a patch which introduces CMake build system > > > in > > > VPP. > > > > > > https://git.fd.io/vpp/commit/?id=612dd6a9 > > > > > > It is initial patch, and additional work is needed, but in > > > general it > > > manages to compile VPP binaries significantly faster > > > than what we have today with autotools. > > > > > > In addition it brings following benefits which we can leverage in > > > the > > > future: > > > - use of CPack to generate deb/rpms vs. hardcoded scripts we > > > have > > > today > > > - much simpler and smaller build definitions specially for > > > plugins > > > - support for different build types (Debug, Release, Release > > > with > > > symbols, Coverage, ...) > > > - support for external components (i.e. we can likely build dpdk > > > and > > > his dependencies) > > > > > > Autotools is still default way to run verify jobs and build > > > images, > > > but people can give CMake a try in few ways: > > > > > > Step 0: "apt-get install cmake ninja-build" > > > > > > - "make {build,rebuild,build-release,rebuild-release}" are > > > already > > > using cmake as default, old behaviour can be restored by saying > > > "make > > > vpp_uses_cmake=no ..." > > > > > > - make -C build-root vpp_uses_cmake=yes PLATFORM=vpp > > > TAG={vpp|vpp_debug} > > > > > > - uncommenting "vpp_uses_cmake=yes" in build- > > > data/platforms/vpp.mk > > > > > > - without ebuild: > > > mkdir _build > > > cd _build > > > cmake [-G Ninja] /path/to/vpp/src > > > -DCMAKE_BUILD_TYPE={Release|Debug} > > > (optionally "ccmake ." to change parameters) > > > {ninja|make} > > > > > > ./bin/vpp unix interactive > > > > > > Building packages (incomplete / work in progress): > > > $ ninja package > > > [0/1] Run CPack packaging tool... > > > CPack: Create package using DEB > > > CPack: Install projects > > > CPack: - Install project: vpp > > > CPack: - Install component: dev > > > CPack: - Install component: plugins > > > CPack: - Install component: vpp > > > CPack: Create package > > > CPack: - package: /home/damarion/tmp/_build/vpp-dev.deb > > > generated. > > > CPack: - package: /home/damarion/tmp/_build/vpp-plugins.deb > > > generated. > > > CPack: - package: /home/damarion/tmp/_build/vpp.deb generated. > > > > > > Feedback, issue reports and contributions to get CMake be a full > > > replacement for autotools are welcome. > > > > > > Thanks, > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > > > > View/Reply Online (#10209): https://lists.fd.io/g/vpp-dev/message > > > /102 > > > 09 > > > Mute This Topic: https://lists.fd.io/mt/24665874/675704 > > > Group Owner: vpp-dev+ow...@lists.fd.io > > > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [ksekera@cisco. > > > com] > > > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10218): https://lists.fd.io/g/vpp-dev/message/10218 Mute This Topic: https://lists.fd.io/mt/24665874/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
