I think what Ed meant to do is to speedup verify job without realizing that test framework does a local install of vpp_papi package which is part of the source tree.
this is correct. So having cached virtualenv is a bad idea as we see already. dont agree…caching internal bits is certainly bad….I just didnt pick out in the rash of 16 other packages getting installed that papi was getting compiled from the tree as opposed to from local src. The whole reason that patch and my cache exists is NOT for speed it was for reliability. (and also not abusing dep code holders (GitHub,pypy,dpdk etc)). I tracked hundreds of failures where intermittent loss of ability to pull dep packages caused entire build/verification failures. That number has effectively dropped to zero. I also wonder whether the caching script watches changes in test/Makefile/PYTHON_DEPENDS and whether adding or changing a dependency would pass a verify job. With every verify run install-dep is run (with ubuntu16 test-dep is also run) this would/will pick up any change Ed, thoughts? I would suggest not to cache virtualenv at all. For now im going to continue to cache but after doing so will nuke: rm -f /var/cache/vpp/python/papi-install.done rm -f /var/cache/vpp/python/virtualenv/lib/python2.7/site-packages/vpp_papi-*-py2.7.egg the papi-install.done is nastier then I thought. Even if ole had rev’d the papi package test-dep would have not properly run do to the presence of that file. On spot testing this will byte-compile with every test-dep on every verify run. Ive rebuilt the cache image with these changes so we will see the results. (things should already be passing, the only noticeable change will be the byte-compile of papi on each and every test-dep) Ed Thanks, Klement On Tue, 2018-06-19 at 08:55 +0200, Ole Troan wrote: Seems like my patch https://gerrit.fd.io/r/#/c/13013/ broke the verification job. I provided a fix, but for some strange reason it seems like the verifiy build is stuck with the broken version of the vpp_papi package. This problem seems to persist even after I reverted 13013 with https: //gerrit.fd.io/r/#/c/13104/<http://gerrit.fd.io/r/#/c/13104/> This is not reproducible locally (since make test uses the correct python package from the build directory there). Anyone knows how to reproduce the verify setup (or have an idea of what's going on?) Cheers, Ole -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9648): https://lists.fd.io/g/vpp-dev/message/9648 Mute This Topic: https://lists.fd.io/mt/22427622/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
