Dear Nitin,
See inline…. > On 31 May 2018, at 19:59, Nitin Saxena <nitin.sax...@cavium.com> wrote: > > Hi, > > I am working on optimising dpdk-input node (based on vpp v1804) for our > target. I am able to get performance improvements on our target but the > problem I am finding now are: > > 1) The dpdk-input code is completely changed on master branch from v1804. Why is this a problem? It was done with reason and for tangible benefit. > Not to mention the dpdk-input master branch code do not give better numbers > on our target as compared to v1804 Sad to hear that, good thing is, it gives better numbers on x86. > 2) I don’t know the modular approach I should follow to merge my changes as I > have completely changed the quad loop handling and the prefetches order in > dpdk-input. I carefully tuned that code. It was multi day exercise and losing single clock/packet on x86 with additional modifications are not acceptable. Still I’m open for discussion how to address this problem. > > Note: I am far away from upstreaming the code currently as my optimisation is > still in progress. It will be better if I know the proper way of doing it. I suggest that you don’t even start on working on upstreaming before we have deep understanding of what and why needs to be done and we are all in agreement. > > Thanks, > Nitin > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9482): https://lists.fd.io/g/vpp-dev/message/9482 View All Messages In Topic (2): https://lists.fd.io/g/vpp-dev/topic/20748102 Mute This Topic: https://lists.fd.io/mt/20748102/21656 New Topic: https://lists.fd.io/g/vpp-dev/post Change Your Subscription: https://lists.fd.io/g/vpp-dev/editsub/21656 Group Home: https://lists.fd.io/g/vpp-dev Contact Group Owner: vpp-dev+ow...@lists.fd.io Terms of Service: https://lists.fd.io/static/tos Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub Email sent to: arch...@mail-archive.com -=-=-=-=-=-=-=-=-=-=-=-
