Thanks Jon. Seems we have an agreed upon an approach now. Just to be sure, let me list the specifics:
1. We will get rid of custom_instance_by_real_instance vector in vxlan_main_t. 2. We will add something like user_instance_by_real_instance hash in vxlan_main_t to track instance usage. 3. We will add u32 instance in vxlan_tunnel_t to keep user specified instance, which will be the same as real instance or index of vxlan tunnel in the tunnels vector in vxlan_main. 4. We will replace the 64 byte if_name in the vxlan_tunnel_details API with u32 instance. 5. We will generate instance-in-use API error if vxlan tunnel creation cannot use the desired instance, either natural or specified. Will review your new patch set when it shows up. Once you patch is merged, I will copy the same mechanism into the GRE tunnel update I am currently working. I will submit my GRE patch for review sometime later and add you as one of the reviewers. Thanks, John From: Jon Loeliger [mailto:j...@netgate.com] Sent: Monday, February 05, 2018 2:26 PM To: John Lo (loj) <l...@cisco.com> Cc: vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] VXLAN Tunnel IF Names On Mon, Feb 5, 2018 at 11:48 AM, John Lo (loj) <l...@cisco.com<mailto:l...@cisco.com>> wrote: One more thang, I would prefer to have a u32 instance number instead of the 64 bytes if_name in the vxlan_tunnel_details API. -John Hi John, I'll work up a patch re-spin using a hash-table, and I will include the if_name -> sw_if_index change mentioned above! Thanks, jdl
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
