Dear Gabriel, We can definitely remove the three files you picked. Once verified, I’ll be glad to merge the patch.
Thanks… Dave From: Gabriel Ganne [mailto:gabriel.ga...@enea.com] Sent: Tuesday, December 5, 2017 10:14 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; vpp-dev@lists.fd.io Subject: Re: some files are never compiled Thanks Dave, I had submitted a pull-request for the smp files here : https://gerrit.fd.io/r/#/c/9730/ Please tell me if I should abandon it and let you do a more complete patch (I don't think I can judge for all the mentioned files by myself). Best regards, -- Gabriel Ganne ________________________________ From: Dave Barach (dbarach) <dbar...@cisco.com<mailto:dbar...@cisco.com>> Sent: Tuesday, December 5, 2017 4:06:09 PM To: Gabriel Ganne; vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: RE: some files are never compiled Dear Gabriel, The files mentioned below fall into several buckets: * Code samples which might reasonably move to .../extras * Things we’re not using at the moment, but which would take someone a good long time to build from scratch. * The simulated annealing driver in vppinfra/anneal.c is a good example. * Debris which should be removed I’ll push a change-set to remove debris. Most of it is mine anyhow... (😉)... Thanks… Dave From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Gabriel Ganne Sent: Tuesday, December 5, 2017 9:52 AM To: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] some files are never compiled Hi, Following a question by Kevin Wang in VPP-1066<https://url10.mailanyone.net/v1/?m=1eMEna-0004JB-5d&i=57e1b682&c=dWeAA22ZVlhnZRfz-i1puxFN8Tk-2rBFyied8Gs8zXDL3Q9k6F90-z0RmbwFTcDpe1fhM2I86d0RWNBHd8VwdvEr6xIUAJFUUGBWtqrQ4SAz6poJV5MSO5svULzjhQ09dOY07pPOvLkZGm5vbduTTwLjeubkD5dEcO6oGql-Kl4gxIbNQD7liXGVkfS6NbeQtSvyOOWcF5cpIdRE6a-t4A_GyvHqKgofPuOcGu8KcWc>, I saw that some files are actually never compiled. Could some external plugin be using them ? Can (Should) they be removed ? As an example, I followed the smp.c, and smp_fido.[ch] files. They have been disabled by commit 01d86c7f6f05938c7d3fe181bd0aa2f75ccdd1df (reviewed here: https://gerrit.fd.io/r/#/c/2273/)<https://url10.mailanyone.net/v1/?m=1eMEna-0004JB-5d&i=57e1b682&c=l-t4hbRfiNUIHcmfdMfBceTCPh9V9nacm3ht2BtvZJdfe6BafPT4y2sAiyKxs3ILFgcCRQf4GEWgCXLfyWhmeR4XvUzjyzRejSl7yqU8A1qfnylWZBISY7Qk5IIaPgwqRx_qTYRI06Y-7wYuAuDsQp_sSnrtQM4oPijSLDSwlaTL_grLpgRDWHWS2iS38TfgV7brBJ9vX20IUGojBeO5oCpxWXrFWkWwLJi4wNGoN5I> almost 1.5 year ago. Here is how I listed them : for file in $(git find "\.c$"); do f=`basename $file .c` ; git grep -q "$f\.c"; if [ $? -eq 1 ] ; then echo $file ; fi ; done src/examples/vlib/plex_test.c src/tools/g2/mkversion.c src/vlib/elog_samples.c src/vlib/parse.c src/vlib/parse_builtin.c src/vnet/ethernet/mac_swap.c src/vnet/fib/fib_entry_src_default.c src/vnet/ip/ip4_test.c src/vnet/map/examples/health_check.c src/vpp/app/sticky_hash.c src/vppinfra/anneal.c src/vppinfra/mod_test_hash.c src/vppinfra/pfhash.c src/vppinfra/phash.c src/vppinfra/qhash.c src/vppinfra/smp.c src/vppinfra/smp_fifo.c src/vppinfra/test_pfhash.c src/vppinfra/test_phash.c src/vppinfra/test_pool.c src/vppinfra/test_qhash.c src/vppinfra/tw_timer_4t_3w_4sl_ov.c src/vppinfra/unix-kelog.c -- Gabriel Ganne
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
