Hi Marco, as you can see in your review build failure, removing -lsubunit breaks existing stuff...
Thanks, Klement Quoting Marco Varlese (2017-10-10 16:46:13) > Hi Klement, > > Yes, once check-devel is in place, then we can remove -lsubunit from > test/ext/Makefile. Things would still work (at least on openSUSE). > > I submitted a patch for review: > https://gerrit.fd.io/r/#/c/8736/ > > > Cheers, > Marco > > On Tue, 2017-10-10 at 14:03 +0000, Klement Sekera -X (ksekera - PANTHEON > TECHNOLOGIES at Cisco) wrote: > > Hi Marco, > > > > this issue is already being investigated by Tom Herbert. Strange thing > > is that check requires subunit. I wonder if it works if you install > > check only. Could you try removing -lsubunit from test/ext/Makefile? > > > > Thanks, > > Klement > > > > Quoting Marco Varlese (2017-10-10 16:00:00) > > > Hi all, > > > > > > As of last week I could happily run tests (e.g. make test) on my > > > distribution > > > (openSUSE). > > > > > > When I tried again today - with latest master - I couldn't anymore: > > > > > > make[2]: Entering directory '/home/mvarlese/repo/vpp/test/ext' > > > cc -o /home/mvarlese/repo/vpp/build-root/vapi_test/vapi_c_test -std=gnu99 > > > -g > > > -Wall -pthread -I/home/mvarlese/repo/vpp/src > > > -I/home/mvarlese/repo/vpp/build- > > > root/install-vpp-native//vpp/include -I/home/mvarlese/repo/vpp/build- > > > root/vapi_test/ vapi_c_test.c -L/home/mvarlese/repo/vpp/build-root/build- > > > vpp- > > > native/vpp/.libs/ -L/home/mvarlese/repo/vpp/build-root/build-vpp- > > > native/vpp/vpp- > > > api/vapi/.libs/ -lvppinfra -lvlibmemoryclient -lsvm -lpthread -lcheck > > > -lsubunit > > > -lrt -lm -lvapiclient > > > /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: > > > cannot > > > find -lsubunit > > > collect2: error: ld returned 1 exit status > > > > > > I tried to find the newly introduced dependency on libsubunit but wasn't > > > successful. > > > > > > Can anybody shed some light? > > > Separate, we do not have that package on our distro... > > > > > > > > > Cheers, > > > Marco > > > > > > _______________________________________________ > > > vpp-dev mailing list > > > vpp-dev@lists.fd.io > > > https://lists.fd.io/mailman/listinfo/vpp-dev _______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
