Decided it was the correct fix and just merged it, thanks.
Chris. From: <vpp-dev-boun...@lists.fd.io> on behalf of "Luke, Chris" <chris_l...@comcast.com> Date: Wednesday, September 20, 2017 at 07:04 To: "Yoann Desmouceaux (ydesmouc)" <ydesm...@cisco.com>, Florin Coras <fcoras.li...@gmail.com>, 薛欣颖 <xy...@fiberhome.com> Cc: vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] memmove fault Thanks Yoann. I’ll review it properly in a bit, have a bit of a drive this morning before I can get to it properly however. On first reading though it seems that it always places the cursor at the end of the line when you cursor up or down. This is consistent with “bash” behavior. Will ponder if that is the behavior we want; I think I tried to deliberately avoid that, but this would be a simple range check if so. Thoughts anyone? Chris. From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Yoann Desmouceaux (ydesmouc) Sent: Wednesday, September 20, 2017 4:22 To: Florin Coras <fcoras.li...@gmail.com>; 薛欣颖 <xy...@fiberhome.com> Cc: vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] memmove fault Hello, I also stumbled upon this bug a few times. I just submitted https://gerrit.fd.io/r/#/c/8468, hopefully this fixes this issue. Cheers, Yoann From: <vpp-dev-boun...@lists.fd.io> on behalf of Florin Coras <fcoras.li...@gmail.com> Date: Wednesday, 20 September 2017 at 08:10 To: 薛欣颖 <xy...@fiberhome.com> Cc: vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] memmove fault Hi, Could this be a result of: type a command in the cli and don’t execute it, press up-arrow, try to input a new command in the empty prompt line, sigsegv? Florin P.S. Chris, apologies, I plead guilty for not trying to debug it … On Sep 19, 2017, at 10:52 PM, 薛欣颖 <xy...@fiberhome.com> wrote: Hi Chris, Until today, the problem only appeared again: Program received signal SIGSEGV, Segmentation fault. __memmove_ssse3_back () at ../sysdeps/x86_64/multiarch/memcpy-ssse3-back.S:1663 1663 ../sysdeps/x86_64/multiarch/memcpy-ssse3-back.S: No such file or directory. (gdb) bt #0 __memmove_ssse3_back () at ../sysdeps/x86_64/multiarch/memcpy-ssse3-back.S:1663 #1 0x00007ffff796531f in unix_cli_line_process_one (cm=0x7ffff7ba6d80 <unix_cli_main>, um=0x7ffff7ba77e0 <unix_main>, cf=0x7fffb5e5bf80, uf=0x7fffb5e5bf24, input=115 's', action=UNIX_CLI_PARSE_ACTION_NOMATCH) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2065 #2 0x00007ffff7965911 in unix_cli_line_edit (cm=0x7ffff7ba6d80 <unix_cli_main>, um=0x7ffff7ba77e0 <unix_main>, cf=0x7fffb5e5bf80) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2154 #3 0x00007ffff7965c49 in unix_cli_process_input (cm=0x7ffff7ba6d80 <unix_cli_main>, cli_file_index=0) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2194 #4 0x00007ffff7966814 in unix_cli_process (vm=0x7ffff7ba7080 <vlib_global_main>, rt=0x7fffb5e5c000, f=0x0) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2320 #5 0x00007ffff7928699 in vlib_process_bootstrap (_a=140736239855696) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/main.c:1275 #6 0x00007ffff695fddc in clib_calljmp () at /home/vpp/17.07_x64/vpp/build-data/../src/vppinfra/longjmp.S:128 #7 0x00007fffb5956820 in ?? () #8 0x00007ffff79287ce in vlib_process_startup (vm=0x7ffff795c5b2 <clib_mem_size+141>, p=0x7fffb5956880, f=0x8496528d2a6d3500) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/main.c:1300 Backtrace stopped: previous frame inner to this frame (corrupt stack?) (gdb) f 1 #1 0x00007ffff796531f in unix_cli_line_process_one (cm=0x7ffff7ba6d80 <unix_cli_main>, um=0x7ffff7ba77e0 <unix_main>, cf=0x7fffb5e5bf80, uf=0x7fffb5e5bf24, input=115 's', action=UNIX_CLI_PARSE_ACTION_NOMATCH) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2065 2065 memmove (cf->current_command + cf->cursor + 1, (gdb) p cf->current_command $36 = (u8 *) 0x7fffb5e5b740 "Ahow interface ipsec-gre " (gdb) p cf->cursor $37 = 15 (gdb) p j $38 = -15 (gdb) Until now I have not figured out the rule that it appears. Thanks, xyxue From: Luke, Chris Date: 2017-08-17 04:54 To: 薛欣颖; vpp-dev@lists.fd.io Subject: RE: [vpp-dev] memmove fault Can you be more specific about the steps that led up to this issue? I won’t be able to work on it until September (about to go on vacation) but I do want to try to capture the details so I can try to recreate it. Chris. From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of ??? Sent: Tuesday, August 15, 2017 5:14 To: vpp-dev@lists.fd.io Subject: [vpp-dev] memmove fault Hi, When I failed to configure a command, then click the up key , there is a Segmentation fault(not every time): Program received signal SIGSEGV, Segmentation fault. __memmove_ssse3_back () at ../sysdeps/x86_64/multiarch/memcpy-ssse3-back.S:1664 1664 ../sysdeps/x86_64/multiarch/memcpy-ssse3-back.S: No such file or directory. (gdb) bt #0 __memmove_ssse3_back () at ../sysdeps/x86_64/multiarch/memcpy-ssse3-back.S:1664 #1 0x00007ffff7966f56 in unix_cli_line_process_one (cm=0x7ffff7ba4960 <unix_cli_main>, um=0x7ffff7ba7dc0 <unix_main>, cf=0x7fffb5de5b3c, uf=0x7fffb5de5ae0, input=102 'f', action=UNIX_CLI_PARSE_ACTION_NOMATCH) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2063 #2 0x00007ffff7967548 in unix_cli_line_edit (cm=0x7ffff7ba4960 <unix_cli_main>, um=0x7ffff7ba7dc0 <unix_main>, cf=0x7fffb5de5b3c) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2152 #3 0x00007ffff7967880 in unix_cli_process_input (cm=0x7ffff7ba4960 <unix_cli_main>, cli_file_index=0) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2192 #4 0x00007ffff796844b in unix_cli_process (vm=0x7ffff7ba7560 <vlib_global_main>, rt=0x7fffb5e70000, f=0x0) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/unix/cli.c:2318 #5 0x00007ffff792a320 in vlib_process_bootstrap (_a=140736239921232) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/main.c:1274 #6 0x00007ffff696fd4c in clib_calljmp () at /home/vpp/17.07_x64/vpp/build-data/../src/vppinfra/longjmp.S:128 #7 0x00007fffb5966820 in ?? () #8 0x00007ffff792a455 in vlib_process_startup (vm=0x7ffff795e1e9 <clib_mem_size+141>, p=0x7fffb5966880, f=0xedcb4a35d968b00) at /home/vpp/17.07_x64/vpp/build-data/../src/vlib/main.c:1299 Backtrace stopped: previous frame inner to this frame (corrupt stack?) How should we solve this problem? Thanks, xyxue _______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
