Hi, You are right, there is a chance to allocate same outside address and port pair for different users. I will fix it (assign a block of port numbers to each worker).
Regards, Matus From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of chupenghong Sent: Wednesday, August 2, 2017 5:15 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] Workers for SNAT may compete for the same outside address and port? Hi all, I read the SNAT plugin code and found that 2 or more worker threads may call the function "snat_alloc_outside_address_and_port" to allocate outside address and port at the same time. Because the address and port are allocated from global varible snat_main.addresses , there is a chance to allocate the same outside address and port for different users. It would be not good for SNAT. I'm not sure I understand the code excatly. Please help me to check out it. Thanks!! Regards chu.penghong
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
