Hi Neal,
I fully agree with you. The intend of my message was to point out the effect of
your patch and the need for an L3 output feature, should VLAN 0 with
appropriate PCP/DEI bits be required on certain output packets.
Regards,
John
-----Original Message-----
From: Neale Ranns (nranns)
Sent: Tuesday, May 30, 2017 2:33 PM
To: John Lo (loj) <l...@cisco.com>; Juraj Linkes -X (jlinkes - PANTHEON
TECHNOLOGIES at Cisco) <jlin...@cisco.com>; otr...@employees.org
Cc: Wojciech Dec (wdec) <w...@cisco.com>; fds-...@lists.opnfv.org;
vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] [Fds-dev] Does VPP support vlan 0?
Hi John,
Do we want VPP to send on VLAN-0 out of a routed port just because [one] host
on that LAN sent a packet VLAN0 encapped? I didn’t think so.
I agree this solution and the sub-interface solution cannot co-exist, but the
trouble with creating a sub-interface for VLAN-0 is that it will be a separate
L3 interface and thus require a different sub-net to the main interface – which
is not the sub-net the sender is in.
I agree with the output feature approach.
Regards,
neale
-----Original Message-----
From: "John Lo (loj)" <l...@cisco.com>
Date: Tuesday, 30 May 2017 at 19:01
To: "Neale Ranns (nranns)" <nra...@cisco.com>, "Juraj Linkes -X (jlinkes -
PANTHEON TECHNOLOGIES at Cisco)" <jlin...@cisco.com>, "otr...@employees.org"
<otr...@employees.org>
Cc: "Wojciech Dec (wdec)" <w...@cisco.com>, "fds-...@lists.opnfv.org"
<fds-...@lists.opnfv.org>, "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>
Subject: RE: [vpp-dev] [Fds-dev] Does VPP support vlan 0?
This patch will force packet with VLAN 0 to be received on the main
sub-interface. If the interface is in L3 mode, it means main interface will
receive packets with either no VLAN or with VLAN 0, as desired by the
requirement. For output on this interface, however, VPP would always send IP
packets without VLAN tag due to its L2 rewrite string in the adj. A work around
to output packets with VLAN 0 would have been to create a VLAN 0 sub-interface.
This patch would make the work around impossible. I suppose if VLAN 0 is
required for some output packets because of the need to set COS bits, the
proper implementation would be to support a L3 output feature to classify the
packets to insert VLAN tag 0 with the appropriate PCP/DEI bits.
If the interface is already in L2 mode, however, current VPP without this
patch would have receive VLAN 0 in the main interface anyway because the
sub-interface lookup in L2 mode is best match and not exact match as in L3 mode.
Regards,
John
-----Original Message-----
From: Neale Ranns (nranns)
Sent: Tuesday, May 30, 2017 10:32 AM
To: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco)
<jlin...@cisco.com>; otr...@employees.org
Cc: Wojciech Dec (wdec) <w...@cisco.com>; fds-...@lists.opnfv.org;
vpp-dev@lists.fd.io; John Lo (loj) <l...@cisco.com>
Subject: Re: [vpp-dev] [Fds-dev] Does VPP support vlan 0?
Hi Juraj,
Please try this:
https://gerrit.fd.io/r/#/c/6936/
which is intended to implement Ole’s suggestion.
thanks,
neale
-----Original Message-----
From: <vpp-dev-boun...@lists.fd.io> on behalf of "Juraj Linkes -X (jlinkes
- PANTHEON TECHNOLOGIES at Cisco)" <jlin...@cisco.com>
Date: Tuesday, 30 May 2017 at 10:19
To: "otr...@employees.org" <otr...@employees.org>
Cc: "Wojciech Dec (wdec)" <w...@cisco.com>, "fds-...@lists.opnfv.org"
<fds-...@lists.opnfv.org>, "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] [Fds-dev] Does VPP support vlan 0?
Hi Ole,
Thanks for the clarification, here's the ticket:
https://jira.fd.io/browse/VPP-870
Juraj
-----Original Message-----
From: otr...@employees.org [mailto:otr...@employees.org]
Sent: Tuesday, 30 May, 2017 10:46
To: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco)
<jlin...@cisco.com>
Cc: Wojciech Dec (wdec) <w...@cisco.com>; John Lo (loj)
<l...@cisco.com>; vpp-dev@lists.fd.io; fds-...@lists.opnfv.org
Subject: Re: [vpp-dev] [Fds-dev] Does VPP support vlan 0?
Juraj,
> That's how I understand it. Doesn't that mean it should work without
the subinterface?
>
> Configuring the sub-interface obviously works. I'm just confused
about how vpp handles this. For example, I don't need to configure
sub-interface for vlan 0 for linux interfaces - the packet doesn't get dropped.
I _think_ correct behaviour for RX on a routed interface is that the
VLAN 0 tag should be ignored. And that you shouldn't need a subinterface in
this case. If we require a subinterface, then we cannot receive tagged with 0
and untagged traffic on the same interface. Something I believe we have to do,
if we want to be compliant for this case.
Open a JIRA?
Best regards,
Ole
>
> Juraj
>
> From: Wojciech Dec (wdec)
> Sent: Monday, 29 May, 2017 15:47
> To: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco)
> <jlin...@cisco.com>; John Lo (loj) <l...@cisco.com>;
> vpp-dev@lists.fd.io
> Cc: fds-...@lists.opnfv.org
> Subject: Re: [Fds-dev] Does VPP support vlan 0?
>
> A frame with VLAN 0 means “I’m on the default VLAN” and “here are my
PCP bits”.
> As John suggested, would be good to ry setting a sub-interface for 0.
>
> Regards,
> -Wojciech.
>
>
> From: <fds-dev-boun...@lists.opnfv.org> on behalf of "Juraj Linkes -X
> (jlinkes - PANTHEON TECHNOLOGIES at Cisco)" <jlin...@cisco.com>
> Date: Monday, 29 May 2017 at 15:08
> To: "John Lo (loj)" <l...@cisco.com>, "vpp-dev@lists.fd.io"
> <vpp-dev@lists.fd.io>
> Cc: "fds-...@lists.opnfv.org" <fds-...@lists.opnfv.org>
> Subject: Re: [Fds-dev] Does VPP support vlan 0?
>
> Hi John,
>
> UCS-B's drivers apparently send vlan 0 in native vlan. I'm just
pointing out that vpp treats vlan id 0 as a vlan when vlan 0 means it's not a
vlan (if I understand the IEEE Std 802.1Q correctly). Or am I missing something?
>
> Thanks,
> Juraj
>
> From: John Lo (loj)
> Sent: Thursday, 25 May, 2017 16:12
> To: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco)
> <jlin...@cisco.com>; vpp-dev@lists.fd.io
> Cc: Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco)
> <tcech...@cisco.com>; fds-...@lists.opnfv.org
> Subject: RE: Does VPP support vlan 0?
>
> Hi Juraj,
>
> For an interface in L3 mode, any packet received with a VLAN tag must
match a sub-interface setup to expect that VLAN tag value. A way to handle this
may be to create a sub-interface matching VLAN 0, such as:
>
> DBGvpp# create sub tuntap-0 0
> tuntap-0.0
> DBGvpp# sho int
> Name Idx State Counter
Count
> GigabitEthernet1b/0/0 3 up rx packets
44630
> rx bytes
4528252
> tx packets
3105
> tx bytes
480292
> drops
20672
> punts
373
> ip4
23551
> GigabitEthernet4/0/0 2 up rx packets
3070
> rx bytes
325990
> tx packets
23549
> tx bytes
2085942
> drops
16
> local0 0 down
> tuntap-0 1 up tx packets
373
> tx bytes
17158
> tuntap-0.0 5 down
> vxlan_tunnel0 4 up rx packets
23549
> rx bytes
2085942
> tx packets
3068
> tx bytes
436318
> DBGvpp# set int state tuntap-0.0 up
>
> I have not tried this kind of setup before and do not know if other
config may be necessary to get this going. One question I do have is why are
you receiving a packet with VLAN tag 0 in your tap interface?
>
> Hopefully this may work for you,
> John
>
> From: vpp-dev-boun...@lists.fd.io
[mailto:vpp-dev-boun...@lists.fd.io]
> On Behalf Of Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at
> Cisco)
> Sent: Thursday, May 25, 2017 4:19 AM
> To: vpp-dev@lists.fd.io
> Cc: Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco)
> <tcech...@cisco.com>; fds-...@lists.opnfv.org
> Subject: Re: [vpp-dev] Does VPP support vlan 0?
>
> Hello vpp-devs,
>
> Has anyone looked at this?
>
> Thanks,
> Juraj
>
> From: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco)
> Sent: Tuesday, 23 May, 2017 15:47
> To: vpp-dev@lists.fd.io
> Cc: fds-...@lists.opnfv.org; Frank Brockners (fbrockne)
> <fbroc...@cisco.com>; Tomas Cechvala -X (tcechval - PANTHEON
> TECHNOLOGIES at Cisco) <tcech...@cisco.com>; Michal Cmarada -X
> (mcmarada - PANTHEON TECHNOLOGIES at Cisco) <mcmar...@cisco.com>
> Subject: Does VPP support vlan 0?
>
> Hi vpp-devs,
>
> I'm hitting an issue when VLAN ID is 0:
> 03:20:01:825468: tapcli-rx
> tap-0
> 03:20:01:825472: ethernet-input
> IP4: 00:25:b5:00:01:4a -> 01:00:5e:00:00:12 802.1q vlan 0
> 03:20:01:825473: error-drop
> ethernet-input: unknown vlan
>
> As I understand it, the device should treat packets with VLAN 0 as if
it didn't have an ID:
> The null VLAN ID. Indicates that the tag header contains only
priority
> information; no VLAN identifier is present in the frame.
>
> I'm trying this with 1704. Does VPP support this? Is there a
workaround, like stripping the 802.1q header for tap ports?
>
> Thanks,
> Juraj
> _______________________________________________
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
