On Mon, Apr 03, 2017 at 04:55:20PM +0000, Neale Ranns (nranns) wrote: > Hi Jeff, > > Thanks for the explanation. > > If we registered the tap-inject-tx node as a local/for-us feature then it > would be get all traffic sent to one of the router’s addresses, regardless of > the L4 protocol. That might be a more robust solution. Local features are a > relatively new concept and presently only for IPv4. But I’ll add them for > IPv6 if you think this is the right approach.
Yeah, that would be more robust. Though, it isn't too bad only needing to register a handful of protocols to get OSPF, RIP, and BGP to work. What you are describing would have been easier initially, but would have taken all the fun out of debugging each protocol one-by-one! > One can then also add unicast/multicast routes as local – which would be how > you might install 224.0.0.0/24 (grep vnet/mfib/mfib_test.c for path_for_us > for an example) It looks like it takes less code to add a multicast route with than the ip4_add_del_route() method, which I appreciate. I must admit it looks slightly less intuitive. However, I understand the new fib is much improved and much more flexible so it expect it would take some getting used to. I think the only reason to change the router plugin would be if the old interfaces went away, which appears to be the case as the fib matures. Other users should comment as I don't actually use it. I only developed the plugin in hopes it would be useful for those in the community by making it very easy to port over existing netlink based control planes. -Jeff > > Regards, > neale > > -----Original Message----- > From: Jeff Shaw <jeffrey.b.s...@intel.com> > Date: Monday, 3 April 2017 at 23:12 > To: "Neale Ranns (nranns)" <nra...@cisco.com> > Cc: 倪红军 <ni_hongj...@163.com>, "Ni, Hongjun" <hongjun...@intel.com>, "Dave > Barach (dbarach)" <dbar...@cisco.com>, Ed Warnicke <hagb...@gmail.com>, > Lukasz Chrustek <ski...@tlen.pl>, "Shaw, Jeffrey B" > <jeffrey.b.s...@intel.com>, "Damjan Marion (damarion)" <damar...@cisco.com>, > "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>, Lukasz Chrustek > <luk...@chrustek.net> > Subject: Re: [vpp-dev] Building router plugin - Mroute > > On Mon, Apr 03, 2017 at 01:10:40PM +0000, Neale Ranns (nranns) wrote: > > Hi Hongjun, > > > > Is there a general mechanism to steer all ‘for-us’ traffic to > tap-inject-neighbor? i.e. given this: > > set int ip address GigE0/0/0 10.10.10.10/24 > > how do packets to 10.10.10.10 get sent to tap-inject-neighbor? > > For the router plugin, you would want IP interface addresses > to be added by the control side, not from vpp, as they would > not be mirrored to the host. The mirroring only happens from > the control to data plane side, not the other way around. I > guess it is more like a one-way mirror used in interrogation > rooms on tv. > > If you did, > > ip addr add 10.10.10.10/24 dev vpp0 > > where vpp0 is the interface associated with GigE0/0/0, then > the router plugin (via the netlink plugin) would hear the > netlink message and apply the address in vpp by calling the > ip4_add_del_interface_address() function. > > When the tap-inject mode was originally enabled on the > interface, the router plugin registered the tap-inject-neighbor > node for ICMP6 and ARP traffic, and tap-inject-tx for ICMP, UDP, > TCP, and OSPF. Neighbor nodes do extra processing (i.e. snooping > the neighbor addresses) while the tap-inject-tx node just copies > packets directly into the tap associated with the interface on > which the packet ingressed. See tap_inject.c:tap_inject_enable(). > > I did a presentation on this topic at the FD.io mini-summit last > year. The slides are somewhat informative. I am not sure if the > video was posted anywhere. > > https://wiki.fd.io/view/File:Dynamic_Routing_on_a_Fast_Data_Plane.pptx > > > -Jeff > > > > > /neale > > > > From: 倪红军 <ni_hongj...@163.com> > > Date: Monday, 3 April 2017 at 13:53 > > To: "Neale Ranns (nranns)" <nra...@cisco.com> > > Cc: "Ni, Hongjun" <hongjun...@intel.com>, "Dave Barach (dbarach)" > <dbar...@cisco.com>, Ed Warnicke <hagb...@gmail.com>, Lukasz Chrustek > <ski...@tlen.pl>, "Shaw, Jeffrey B" <jeffrey.b.s...@intel.com>, "Damjan > Marion (damarion)" <damar...@cisco.com>, "vpp-dev@lists.fd.io" > <vpp-dev@lists.fd.io>, Lukasz Chrustek <luk...@chrustek.net> > > Subject: Re:Re: [vpp-dev] Building router plugin - Mroute > > > > Hi Neale, > > > > The intent of this classification is to direct OSPF packet to the node > tap-inject-neighbor, > > Then the OSPF packet can be redirected to BIRD in Hosting system. > > > > Thanks a lot, > > Hongjun > > > > > > At 2017-04-01 17:42:28, "Neale Ranns (nranns)" > <nra...@cisco.com<mailto:nra...@cisco.com>> wrote: > > > > > > Hi Hongjun, > > > > The new Multicast FIB in 17.04 removed the classify option for > multicast routes. May I ask the intent of the classification you want to > achieve? Maybe there is a way to get that behaviour with the new mechanisms. > > > > Thanks, > > neale > > > > From: <vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io>> > on behalf of "Ni, Hongjun" <hongjun...@intel.com<mailto:hongjun...@intel.com>> > > Date: Saturday, 1 April 2017 at 07:11 > > To: "Dave Barach (dbarach)" > <dbar...@cisco.com<mailto:dbar...@cisco.com>>, Ed Warnicke > <hagb...@gmail.com<mailto:hagb...@gmail.com>>, Lukasz Chrustek > <ski...@tlen.pl<mailto:ski...@tlen.pl>> > > Cc: "Shaw, Jeffrey B" > <jeffrey.b.s...@intel.com<mailto:jeffrey.b.s...@intel.com>>, "Damjan Marion > (damarion)" <damar...@cisco.com<mailto:damar...@cisco.com>>, > "vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" > <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>>, Lukasz Chrustek > <luk...@chrustek.net<mailto:luk...@chrustek.net>> > > Subject: Re: [vpp-dev] Building router plugin > > > > Hey Luk, > > > > I have fixed some issues in netlink and router plugin in below patch: > Now it can work with VPP. > > https://gerrit.fd.io/r/#/c/5881/ Fix compile issue for netlink and > router plugin > > > > Build script is: > > cd /root/vpp > > ln -sf /root/vpp/vppsb/netlink > > ln -sf /root/vpp/vppsb/router > > ln -sf /root/vpp/vppsb/netlink/netlink.mk build-data/packages/ > > ln -sf /root/vpp/vppsb/router/router.mk build-data/packages/ > > > > cd /root/vpp/build-root > > make V=0 PLATFORM=vpp TAG=vpp_debug netlink-install router-install > > > > ln -sf > /root/vpp/build-root/install-vpp_debug-native/router/lib64/router.so.0.0.0 \ > > /usr/lib/vpp_plugins/router.so > > > > I tested it with VPP master using below script: and it works. > > enable tap-inject > > > > classify table mask l3 ip4 proto > > ip route add 10.0.0.4/30 via classify 0 > > ip route add 10.0.0.22/32 via classify 0 > > classify session hit-next ip4-node tap-inject-neighbor table-index 0 > match l3 ip4 proto 89 > > classify session hit-next ip4-node tap-inject-neighbor table-index 0 > match l3 ip4 proto 2 > > > > But it seems that VPP master failed to add multicast route via > classify table, because ip_mroute_command does not support this. > > DBGvpp# ip mroute add 224.0.0.4/30 via classify 0 > > ip mroute: parse error `via classify 0' > > I am not sure whether ip_mroute_command will add it later? > > > > In VPP stable/1701, all multicast routes are added through “ip route > add” command, so below configuration works in stable/1701. > > ip route add 224.0.0.4/30 via classify 0 > > I also have a patch that can work well in VPP stable/1701. If required, > I can send it to you. > > > > Thanks Dave and Shaw, Jeffrey for your great help! > > > > Regards, > > Hongjun > > > > From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> > [mailto:vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io>] On > Behalf Of Ni, Hongjun > > Sent: Wednesday, March 29, 2017 9:51 AM > > To: Dave Barach (dbarach) > <dbar...@cisco.com<mailto:dbar...@cisco.com>>; Ed Warnicke > <hagb...@gmail.com<mailto:hagb...@gmail.com>>; Lukasz Chrustek > <ski...@tlen.pl<mailto:ski...@tlen.pl>> > > Cc: Shaw, Jeffrey B > <jeffrey.b.s...@intel.com<mailto:jeffrey.b.s...@intel.com>>; Damjan Marion > (damarion) <damar...@cisco.com<mailto:damar...@cisco.com>>; > vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>; Lukasz Chrustek > <luk...@chrustek.net<mailto:luk...@chrustek.net>> > > Subject: Re: [vpp-dev] Building router plugin > > > > Thanks Dave. Will look into it. > > > > From: Dave Barach (dbarach) [mailto:dbar...@cisco.com] > > Sent: Tuesday, March 28, 2017 7:52 PM > > To: Ni, Hongjun <hongjun...@intel.com<mailto:hongjun...@intel.com>>; Ed > Warnicke <hagb...@gmail.com<mailto:hagb...@gmail.com>>; Lukasz Chrustek > <ski...@tlen.pl<mailto:ski...@tlen.pl>> > > Cc: Shaw, Jeffrey B > <jeffrey.b.s...@intel.com<mailto:jeffrey.b.s...@intel.com>>; Damjan Marion > (damarion) <damar...@cisco.com<mailto:damar...@cisco.com>>; > vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>; Lukasz Chrustek > <luk...@chrustek.net<mailto:luk...@chrustek.net>> > > Subject: RE: [vpp-dev] Building router plugin > > > > FWIW: I sent diffs to fix the build-system integration over the > weekend, as well as a fair fraction of the FIB 2.0 integration... > > > > Thanks… Dave > > > > From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> > [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Ni, Hongjun > > Sent: Monday, March 27, 2017 10:32 PM > > To: Ed Warnicke <hagb...@gmail.com<mailto:hagb...@gmail.com>>; Lukasz > Chrustek <ski...@tlen.pl<mailto:ski...@tlen.pl>> > > Cc: Shaw, Jeffrey B > <jeffrey.b.s...@intel.com<mailto:jeffrey.b.s...@intel.com>>; Damjan Marion > (damarion) <damar...@cisco.com<mailto:damar...@cisco.com>>; > vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>; Lukasz Chrustek > <luk...@chrustek.net<mailto:luk...@chrustek.net>> > > Subject: Re: [vpp-dev] Building router plugin > > > > Hi Luk, > > > > We are using netlink and router plugin in VPP stable 17.01, and also > met the same issue. > > > > I have submitted a patch to fix a compile issue in netlink for review, > now netlink could compile ok in VPP stable 17.01. > > https://gerrit.fd.io/r/#/c/5881/ FIx compile issue for netlink > > > > I am working on router plugin now, hope to address some issues and make > it work again in VPP stable 17.01. > > > > For VPP 17.04, make file may need to be changed as per new building > system. > > > > Regards, > > Hongjun > > > > From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> > [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Ed Warnicke > > Sent: Tuesday, March 28, 2017 6:10 AM > > To: Łukasz Chrustek <ski...@tlen.pl<mailto:ski...@tlen.pl>> > > Cc: Damjan Marion (damarion) > <damar...@cisco.com<mailto:damar...@cisco.com>>; Lukasz Chrustek > <luk...@chrustek.net<mailto:luk...@chrustek.net>>; > vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>; Shaw, Jeffrey B > <jeffrey.b.s...@intel.com<mailto:jeffrey.b.s...@intel.com>> > > Subject: Re: [vpp-dev] Building router plugin > > > > You might also look at > > > > https://gerrit.fd.io/r/#/c/5004/ - which introduces memif interfaces... > which I think Damjan eventually wants a library for so that you could > > use them for things like taps for routing protocol packets... > > > > Ed > > > > On Mon, Mar 27, 2017 at 2:43 PM, Łukasz Chrustek > <ski...@tlen.pl<mailto:ski...@tlen.pl>> wrote: > > Hi, > > > > Ok, thank You. I will give a try with earlier version of vpp, as Jeff > > suggests. I have running netlink plugin, but as Ole wrote - most > > important is router plugin. > > > > Cheers, > > Luk > > > > >> You basically have two options: > > >> 1. Teach your routing protocol daemon to directly talk to VPP for > configuring the FIB. > > >> 2. Do not modify the routing daemon and let VPP map routes written > in the kernel. > > >> > > >> For 1, you will need the router plugin, but for packet punting only. > > >> > > >> For 2., you will need both netlink+router plugins. The netlink > plugin (which actually more like a library), shouldn't require so much > changes though. > > > > > With TCP support in VPP I was playing with the idea of integrating > exaBGP as a VPP plugin. > > > Use the Python API binding to program routes, and receive the BGP > > > stream across a fifo (or even the API). > > > > > Cheers, > > > Ole > > > > >>> Le 26 mars 2017 à 16:31, Łukasz Chrustek > <ski...@tlen.pl<mailto:ski...@tlen.pl>> a écrit : > > >>> > > >>> Hello, > > >>> > > >>> thank all of You for clarification of status router plugin. > > >>> > > >>> I'm trying to use vpp+dpdk as bare metal linux ruter with bgp and > ospf routing protocols, goal is to make very fast router with dynamic routing > protocols. Can You advice is there any other way to exchange dynamic routing > information between os and vpp ? > > >>> > > >>> Regards > > >>> Lukasz > > >>> > > >>> > > >>> The mailman did not let my last message go through because it was > too big so I am removing the previous threads to keep this message under > 100KB limit. > > >>> > > >>> Hello, > > >>> > > >>> Dave and Pierre are correct, the router plugin is no longer being > maintained. There was not much interest in the community for this project at > the time and I have since moved on to other things. I’d be happy to help a > new maintainer with any questions they may have. > > >>> > > >>> If you really want to just test it out, I suggest attempting to > checkout a commit of VPP close to the last commit on the router plugin. > Somewhere closely following VPP commit 0bfe5d8c792abcdb, “A Protocol > Independent Hierarchical FIB (VPP-352)” will work (you might have to git > bisect to get something that compiles right away). > > >>> > > >>> If necessary, I can submit a patch to remove the router plugin from > the VPP sandbox with a note on the wiki page mentioning the finalization of > the project. I recall there being an 8-month time limit for these the sandbox > projects. > > >>> > > >>> -Jeff > > >>> > > >>> > > >>> > > >> > > >> _______________________________________________ > > >> vpp-dev mailing list > > >> vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> > > >> https://lists.fd.io/mailman/listinfo/vpp-dev > > -- > > Pozdrowienia, > > Łukasz Chrustek > > > > _______________________________________________ > > vpp-dev mailing list > > vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> > > https://lists.fd.io/mailman/listinfo/vpp-dev > > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
