Damjan,

Thanks!


On 03/24/2017 12:34 PM, Damjan Marion (damarion) wrote:

On 23 Mar 2017, at 14:26, Thomas F Herbert <therb...@redhat.com <mailto:therb...@redhat.com>> wrote:



On 03/22/2017 04:36 PM, Feng Pan wrote:
So this would suggest that VPP by default (that is, by doing 'yum install vpp') will not have dpdk support, and vpp-plugins must also be installed to add it, I would think dpdk plugin should be either packaged or installed together with VPP by default, and can be disabled if desired.

In any case, will deployment model stay this way? I'll need to make changes to puppet module to include other packages if that's how it will be going forward. Also, dpdk section should be commented out in the config file so we can start VPP service using the default config.
The dpdk plugin build process precipitated major headaches working for downstream packaging for Centos as well. I had a patch ready to submit for building from a dist tarball as a step toward building from a source rpm but that can't be used now. The main problem is vpp can no longer build from a isolated tarball without git.

Out-of-tree build problem is very easily fixable, as I suggested in the review comments.It is unlikely to be more than 10 lines of shell script.
Yes, I agree. It turns out to be a minor problem. I have a patch I will soon submit which will fix this.

Installing the development rpm as part of downstream installation is not an option either.

installation of devel rpm is not mandatory step, you can build vpp without development package installed.
Yes, correct. The coming patch will utilize the dpdk tarball for now.

The build process does not support dependency on an external rpm yet such as that which is built in rpm_dpdk project. I am thinking out load here but the best option for achieving packaging for 17.04 is to build dpdk from the tarball, bypass the dpdk rpm and include the upstream dpdk tarball in the srpm. Hopefully we can get a better solution figured out by next release over 17.0x that will work with the dpdk plugin concept.

I’m not getting what is wrong with current setup, vpp is simple autotools project and packaging is free to invoke “cd src; ./configure; make; make install” as it is done with hundreds of different projects.
There is nothing wrong with the current setup. It is an improvement to have DPDK as a plugin. I had to update the script for creating the dist and had to make a few minor changes to the dpdk Makefile that shouldn't affect current builds.







--
*Thomas F Herbert*
SDN Group
Office of Technology
*Red Hat*
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to