I submitted patch to fix this problem, https://gerrit.fd.io/r/#/c/5709/
Please review
On 03/08/2017 06:36 PM, Thomas F Herbert wrote:
I have been working on a patch to build a SRPM for downstream
packaging but ran into a problem and need more eyes.
This is dependent on my earlier patch for building a dist tarball
20a29c7b4d1b5b68112498bee21ee7f3fe123b13 which encapsulates the
version metadata in a .version file in build-root/scripts. The version
metadata can be determined from within the tarball when there is no
git which is done by executing build-root/scripts/version which will
work with or without git.
See JIRA-498
However, now, this is broken by newer build changes which generates a
different .version in build-root/build-vpp-native/vpp and this
.version is used to construct the file version.h which is a dependency
for the builds to work.
I looked at src/vpp.am and it "looks like" the .version target should
work because of:
VPP_VERSION = $(shell $(srcdir)/scripts/version)
but I think that it should check for a non zero exit code from git
rev-parse.
Steps to reproduce
$ cd tmp
$ git clone ....
$ cd vpp
$ make dist
$ cd ..
$ xzf ../vpp/build-root/rpm/vpp-17.04-rc0~395_gd96bad8.tar.gz
$ cd vpp-17.04
$ make bootstrap
$ make build-release
...
CC vpp/vnet/bin_vpp-main.o
/home/therbert/tmp/dist/vpp-17.04/build-data/../src/vpp/vnet/main.c:21:29:
fatal error: vpp/app/version.h: No such file or directory
compilation terminated.
Full results in
https://gist.github.com/tfherbert/3e26ab4ce8989ba35158573ccc641591
Thanks for looking at this.
--
*Thomas F Herbert*
SDN Group
Office of Technology
*Red Hat*
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
