Please fix merge conflict(s) in https://gerrit.fd.io/r/#/c/4715/5
Thanks… Dave From: Andrej Macak -X (amacak - PANTHEON TECHNOLOGIES at Cisco) Sent: Friday, February 17, 2017 9:34 AM To: vpp-dev@lists.fd.io Cc: michal.janc...@pantheon.tech; Dave Barach (dbarach) <dbar...@cisco.com>; Pavel Kotucek -X (pkotucek - PANTHEON TECHNOLOGIES at Cisco) <pkotu...@cisco.com> Subject: RE: VPP-540 : pbb tag rewrite details Dear VPP community, I would like to kindly ask you could review and merge commit: https://gerrit.fd.io/r/#/c/4715/ Thank you, Andrej From: Pavel Kotucek -X (pkotucek - PANTHEON TECHNOLOGIES at Cisco) Sent: Thursday, February 9, 2017 9:51 To: Dave Barach (dbarach) <dbar...@cisco.com<mailto:dbar...@cisco.com>> Cc: michal.janc...@pantheon.tech<mailto:michal.janc...@pantheon.tech>; Andrej Macak -X (amacak - PANTHEON TECHNOLOGIES at Cisco) <ama...@cisco.com<mailto:ama...@cisco.com>> Subject: Re: VPP-540 : pbb tag rewrite details Dear Dave, finally I ran vpp-csit-verify-hw-perf-master-long (as short one fails in VAT - no JSON data) and with help of Peter Mikus we compared results with referencing values https://jenkins.fd.io/view/vpp/job/vpp-csit-verify-hw-perf-master-long/1039/consoleFull https://docs.fd.io/csit/rls1701/report/detailed_test_results/vpp_performance_results/vpp_performance_results.html Results seem to be in tolerance (as Peter said me tolerance is +/- 200 Kpps). So from this point of view changes in 4715 doesn't impact performance of vpp. Regards Pavel ________________________________ From: Dave Barach (dbarach) Sent: Tuesday, February 7, 2017 3:22 PM To: Pavel Kotucek -X (pkotucek - PANTHEON TECHNOLOGIES at Cisco); Damjan Marion (damarion); Ole Troan (otroan); John Lo (loj); Keith Burns (krb); Florin Coras (fcoras) Cc: michal.janc...@pantheon.tech<mailto:michal.janc...@pantheon.tech>; Andrej Macak -X (amacak - PANTHEON TECHNOLOGIES at Cisco) Subject: RE: VPP-540 : pbb tag rewrite details At a glance, the changes look OK. Please pass along csit or equivalent L2 performance test results. I’ve -2’ed the patch until performance test results demonstrate that the patch does no harm. Thanks… Dave From: Pavel Kotucek -X (pkotucek - PANTHEON TECHNOLOGIES at Cisco) Sent: Tuesday, February 7, 2017 9:15 AM To: Dave Barach (dbarach) <dbar...@cisco.com<mailto:dbar...@cisco.com>>; Damjan Marion (damarion) <damar...@cisco.com<mailto:damar...@cisco.com>>; Ole Troan (otroan) <otr...@cisco.com<mailto:otr...@cisco.com>>; John Lo (loj) <l...@cisco.com<mailto:l...@cisco.com>>; Keith Burns (krb) <k...@cisco.com<mailto:k...@cisco.com>>; Florin Coras (fcoras) <fco...@cisco.com<mailto:fco...@cisco.com>> Cc: michal.janc...@pantheon.tech<mailto:michal.janc...@pantheon.tech>; Andrej Macak -X (amacak - PANTHEON TECHNOLOGIES at Cisco) <ama...@cisco.com<mailto:ama...@cisco.com>> Subject: VPP-540 : pbb tag rewrite details Dear Committers, according the info from page https://wiki.fd.io/view/VPP/Committers/SMEs I would like to ask one of you as committers to do review (and merge if possible) for commit https://gerrit.fd.io/r/#/c/4715/ This task is related to JIRA https://jira.fd.io/browse/VPP-540 and was requested by INMARSAT team. According info from INMARSAT project leader Andrej Macak it was agreed by Emran and Jan. Commit #4715 adds small improvements required by INMARSAT in interface dump and packet tracing. If I have to ask somebody else to review and merge this code please let me know. Thank you Regards Pavel
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
