Hi Jon,

fib_urpf_list.h needs to included inside the source file and need not be 
installed in /usr/include. Thanks for raising this. I will send out a patch for 
this.

Regards,
Akshaya N

From: <vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io>> on 
behalf of Jon Loeliger <j...@netgate.com<mailto:j...@netgate.com>>
Date: Friday, 10 February 2017 at 1:22 AM
To: vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>>
Subject: [vpp-dev] Failing Out-of-tree Builds

Folks,

On Tuesday, this commit went in:
commit 8ea6d7153b053f1b9bf837ef3a927136f44b41fd
Author: AkshayaNadahalli <anada...@cisco.com<mailto:anada...@cisco.com>>
Date:   Tue Feb 7 23:59:54 2017 +0530

   Fix source address reachability check for ip6 local packets

It contained this hunk:

diff --git a/src/vnet/fib/ip6_fib.h b/src/vnet/fib/ip6_fib.h
index 78da374..e460e2f 100644
--- a/src/vnet/fib/ip6_fib.h
+++ b/src/vnet/fib/ip6_fib.h
@@ -20,6 +20,7 @@
#include <vnet/ip/format.h>
#include <vnet/fib/fib_entry.h>
#include <vnet/fib/fib_table.h>
+#include <vnet/fib/fib_urpf_list.h>
#include <vnet/ip/lookup.h>
#include <vnet/dpo/load_balance.h>

Now, that all builds fine internally to the source tree itself, but it fails 
for out-of-tree builds relying on an installed (RPM) package.  The file, 
fib_urpf_list.h, needs to now be included in the set of files installed in the 
RPM includes.

Alternatively, if that fib_urpf_list.h isn't intended to be installed in 
/usr/include/, then it
shouldn't be an #include line in the ip6_fib.h file.  Maybe it just needs to be 
included
in the actual C source file that needs it.  I don't know the intent here, or 
I'd send a patch.

Thanks,
jdl

_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to