Hey,

Currently, it seems that there is a compiling failure occurred on NSH_SFC 17.04 
master.
I took a look at VPP code and found that there are some changes on JVPP and 
plugin framework in VPP recently.
So I created a patch to fix this:
https://gerrit.fd.io/r/#/c/5030/ Fix compile issue due to jvpp and plugin 
improvement

This patch worked well on Ubuntu 14.04 and Ubuntu 16.04 in my local development 
environment.
When I submitted this patch to gerrit, it succeeded on Ubuntu 14.04 and CentOS 
7, but failed on Ubuntu 16.04.

The below is the build failure from ubuntu16.04:
Could you give some advice on how to fix this issue?  Thanks in advance.
For details, please refer to 
https://jenkins.fd.io/job/nsh_sfc-verify-master-ubuntu1604/1199/console

make[2]: Entering directory 
'/w/workspace/nsh_sfc-verify-master-ubuntu1604/nsh-plugin/build'
/bin/bash ./libtool  --tag=CC   --mode=compile gcc 
-DPACKAGE_NAME=\"nsh_plugin\" -DPACKAGE_TARNAME=\"nsh_plugin\" 
-DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"nsh_plugin\ 1.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"nsh_plugin\" 
-DVERSION=\"1.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -I. -I..  -DDEBUG -g -DDEBUG -g -Wall -I. -g -O2 -MT 
nsh/nsh_plugin_la-nsh.lo -MD -MP -MF nsh/.deps/nsh_plugin_la-nsh.Tpo -c -o 
nsh/nsh_plugin_la-nsh.lo `test -f 'nsh/nsh.c' || echo '../'`nsh/nsh.c
libtool: compile:  gcc -DPACKAGE_NAME=\"nsh_plugin\" 
-DPACKAGE_TARNAME=\"nsh_plugin\" -DPACKAGE_VERSION=\"1.0\" 
"-DPACKAGE_STRING=\"nsh_plugin 1.0\"" -DPACKAGE_BUGREPORT=\"\" 
-DPACKAGE_URL=\"\" -DPACKAGE=\"nsh_plugin\" -DVERSION=\"1.0\" -DSTDC_HEADERS=1 
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I.. -DDEBUG -g 
-DDEBUG -g -Wall -I. -g -O2 -MT nsh/nsh_plugin_la-nsh.lo -MD -MP -MF 
nsh/.deps/nsh_plugin_la-nsh.Tpo -c ../nsh/nsh.c  -fPIC -DPIC -o 
nsh/.libs/nsh_plugin_la-nsh.o
../nsh/nsh.c:108:1: warning: data definition has no type or storage class
VLIB_PLUGIN_REGISTER () = {
^
../nsh/nsh.c:108:1: warning: type defaults to 'int' in declaration of 
'VLIB_PLUGIN_REGISTER' [-Wimplicit-int]
../nsh/nsh.c:108:1: error: function 'VLIB_PLUGIN_REGISTER' is initialized like 
a variable
../nsh/nsh.c:108:27: error: empty scalar initializer
VLIB_PLUGIN_REGISTER () = {
                           ^
../nsh/nsh.c:108:27: note: (near initialization for 'VLIB_PLUGIN_REGISTER')
Makefile:556: recipe for target 'nsh/nsh_plugin_la-nsh.lo' failed
make[2]: *** [nsh/nsh_plugin_la-nsh.lo] Error 1
make[2]: Leaving directory 
'/w/workspace/nsh_sfc-verify-master-ubuntu1604/nsh-plugin/build'
Makefile:610: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory 
'/w/workspace/nsh_sfc-verify-master-ubuntu1604/nsh-plugin/build'
Makefile:431: recipe for target 'all' failed
make: *** [all] Error 2

Thanks a lot,
Hongjun

_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to