That patch was the result of a less-than-optimal cleanup effort on my part. Until I did that, the plugins had their own copies of the M, M2, S, and W macros, each of which had some version of (VL_API_MUMBLE + plugin_msg_base).
I fucked up all of them in one motion when I got rid of N-1 cut-‘n-paste replicas of the M, M2, S, and W macros. All of the csit tests passed - they use they Python language binding - nobody noticed until I got around to answering your email. I said several rude words you never read in the Bible, and set about fixing the problem. Thanks… Dave From: Jon Loeliger [mailto:j...@netgate.com] Sent: Friday, January 27, 2017 10:24 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] SNAT Plugin Use On Thu, Jan 26, 2017 at 4:38 PM, Jon Loeliger <j...@netgate.com<mailto:j...@netgate.com>> wrote: Does this same mechanism hold true for the VPE messages? Is the collection of the VPE message considered "a plugin", or "a base onto which plugins will be added"? There are currently 20 or 21 include files' worth of msg ids here. Specifically, I'm trying to resolve an understanding of what I was told to do last week (Use a msg_id based on a lookup of "<name>_<crc>") versus this use a msg_id obtained by "base + enum-value". Is there a plugin name for the VPE collection of API msg ids? (I don't think so.) Will these msg_ids always be 0-based so no base offset need be looked-up nor added? Thanks, jdl Dave, So, I feel like I may be a day late and a dollar short each time I ask a question. Like above. So I just couldn't see where this base msg_id addition was taking place... And about the time I was trying to figure it out, this commit happened: author Dave Barach <d...@barachs.net<mailto:d...@barachs.net>> 2017-01-25 16:32:08 -0500 commit 2d6b2d6d1bbb130921ec525a1cc6e88f42717c79 (patch) Repair plugin binary API message numbering Change-Id: I422a3f168bd483e011cfaf54af022cb79b78db02 Signed-off-by: Dave Barach <d...@barachs.net<mailto:d...@barachs.net>> Which pretty much answers my question. Are my questions the forcing function here? :-) Or am I just on the bleeding edge? jdl
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
