Hi Damjan, Regarding the diffs, do you know in which error case(s) the retry will hit the most to cause such a big improvement in NDR? I have counted no less than 8 got done in the outer loop and it seems to me some of the error cases should not be retried at all (e.g. VHOST_USER_TX_FUNC_ERROR_INDIRECT_OVERFLOW line 1853)? Lastly, he max retry is hardcoded at 8 (line 1816), do you feel like this will work out the same retry value in all vpp ports? If not it might be worth making it a vpp config parameter.
Also which performance test did you run to see the 40% improvement? Thanks Alec From: <vpp-dev-boun...@lists.fd.io> on behalf of "Damjan Marion (damarion)" <damar...@cisco.com> Date: Thursday, November 24, 2016 at 3:21 AM To: vpp-dev <vpp-dev@lists.fd.io> Subject: [vpp-dev] native vhost-user perf improvements I know that several people are playing with VPP vhost-user implementation so just a heads-up about latest change in master which really helps with NDR performance. We are observing NDR gain of 41% in our testbeds. https://git.fd.io/vpp/commit/?id=4e969f9 Let me know if any issues, or just feedback how it works. Thanks, Damjan _______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> https://lists.fd.io/mailman/listinfo/vpp-dev
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
