Dear Ole, Yes, the reorganization I have in mind will yield a single API composed from N .api / .c files. As I wrote, the reorganization is about reducing patch merge / rebase pain; to a lesser extent about api placement within the vpp source tree.
My plan is to yank apart vpe.api / api.c, forming several pieces: Api.c top boilerplate -> moves to a shared header file. (*) Message handlers, foreach macros -> individual .c files Message definitions -> individual .api files Vpe_all_api_h.h <- list of all foo.api.h files, invent new foreach macro (**) Dealing with the API checksum will take a bit of tap dancing. It's probably best to let me deal with that specific hemorrhoid. (***) You can extract map APIs from the main .api definition at any time. If you're not in a hurry, it might be best to wait until I've deal with (*), (**), and (***) Thanks… Dave -----Original Message----- From: Ole Troan [mailto:o...@cisco.com] Sent: Monday, October 31, 2016 4:43 AM To: Dave Barach (dbarach) <dbar...@cisco.com> Cc: Luke, Chris <chris_l...@comcast.com>; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Clean-up tasks: 17.01 F0 -> RC0 > It’s an SMT [simple matter of typing] to create a number xxx.api files, > related message handler implementation files, and to place them next to > whatever the indicate API collection controls. > > The current setup is a historical artifact. I'll have a go at the MAP APIs ASAP. (Been on my list for a while). I expect we will continue to threat the sub-modules as one API definition, not as separate "plugins". Cheers, Ole > > Thanks… Dave > > From: Luke, Chris [mailto:chris_l...@comcast.com] > Sent: Thursday, October 27, 2016 4:19 PM > To: Dave Barach (dbarach) <dbar...@cisco.com>; vpp-dev@lists.fd.io > Subject: RE: Clean-up tasks: 17.01 F0 -> RC0 > > Sounds good to me. The api files in particular strike me as unmanageably > large right now. I’ve especially wondered if the API code for each “thing” > can move physically closer the “thing” it provides an interface for. > > Chris. > > From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On > Behalf Of Dave Barach (dbarach) > Sent: Thursday, October 27, 2016 4:07 PM > To: vpp-dev@lists.fd.io > Subject: [vpp-dev] Clean-up tasks: 17.01 F0 -> RC0 > > Folks, > > I’d like to suggest that we undertake several clean-up tasks once we reach > the 17.01 F0 (API freeze) milestone: > > · Clean up Coverity warnings > · Split .../vpp/vpp-infra/{vpe.api, api.c} into groups of related > APIs, to reduce future merge collisions > · Finish .../vnet coding standards cleanup > · Add documentation > > Thoughts? > > Thanks... Dave > _______________________________________________ > vpp-dev mailing list > vpp-dev@lists.fd.io > https://lists.fd.io/mailman/listinfo/vpp-dev _______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
