Klement,

Thanks for helping improve the java build infrastructure.

I think that you may find that the execution of the build system is very different on the LF cloud infrastructure then on a typical development platform. IIRC, this is not the first time we've been bitten by that particular bug.

Here is Marek's patch which fixed this issue earlier: https://gerrit.fd.io/r/#/c/3131

Looking at your patch, I think this deletion may be the primary culprit in opening up the race condition:

   -EXTRA_libjvpp_registry_la_DEPENDENCIES=libjvpp_common.la

I think it would be worth pushing a patch with that dependency restored before reverting the entire patch.

Thanks,
-daw-

On 10/20/2016 12:24 PM, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco) wrote:

It's quite possible, I've made multiple builds and rebuilds to make sure I didn't break anything, but I apparently did. Feel free to revert the patch and I'll take a look at it again. That java build stuff is a real mess...

Klement


On Oct 20, 2016 6:22 PM, Edward Warnicke <hagb...@gmail.com> wrote:

    This change:

    https://gerrit.fd.io/r/#/c/3486/

    Was touching that part of the world... *if* it is a race
    condition, is it possible that this patch got lucky, and the ones
    that followed did not?

    Ed

    On Thu, Oct 20, 2016 at 9:15 AM, Dave Wallace
    <dwallac...@gmail.com <mailto:dwallac...@gmail.com>> wrote:

        Maciek,

        This looks like a race condition in the build for JVPP.  All
        of the failures contain the following error:

            09:32:35 make[5]: Entering directory
            
'/w/workspace/vpp-verify-master-ubuntu1604/build-root/build-vpp-native/vpp-api/java'
            09:32:35   CC jvpp-common/libjvpp_common_la-jvpp_common.lo
            09:32:35   CC jvpp-core/libjvpp_core_la-jvpp_core.lo
09:32:35 CC jvpp-registry/libjvpp_registry_la-jvpp_registry.lo
            09:32:39   CCLD libjvpp_common.la <http://libjvpp_common.la>
            09:32:39   CCLD libjvpp_registry.la
            <http://libjvpp_registry.la>
            09:32:40 ar: `u' modifier ignored since `D' is the default
            (see `U')
            09:32:40 /usr/bin/ld: cannot find -ljvpp_common
            09:32:40 collect2: error: ld returned 1 exit status
            09:32:40 Makefile:551: recipe for target
            'libjvpp_registry.la <http://libjvpp_registry.la>' failed

        It appears that the output of "CCLD libjvpp_common.la
        <http://libjvpp_common.la>" is an input to "CCLD
        libjvpp_registry.la <http://libjvpp_registry.la>" and in the
        error case it is not found.

        I had thought that Maros or Marek had provided a fix for this
        issue a couple of weeks ago. When I get the chance investigate
        further.

        Thanks,
        -daw-


        On 10/20/2016 10:31 AM, Maciek Konstantynowicz (mkonstan) wrote:

            Hi,

            Anybody with time and willingness to look at below jobs
            and see why they pass 1st time and fail 2nd time,
            ie not repeatable..

            All running on the new ubuntu1604 VMs in VIRL. Related to
            two vpp patches:

            https://gerrit.fd.io/r/#/c/3499/
            <https://gerrit.fd.io/r/#/c/3499/>
            https://jenkins.fd.io/job/vpp-csit-verify-virl-master/1838/ 
<https://jenkins.fd.io/job/vpp-csit-verify-virl-master/1838/>
            : SUCCESS
            https://jenkins.fd.io/job/vpp-csit-verify-virl-master/1841/ 
<https://jenkins.fd.io/job/vpp-csit-verify-virl-master/1841/>
            : FAILURE

            Seem to be vpp build related, as the standalone ubuntu1604
            build jobs for this patch are also yielding not repeatable
            results:
            https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/1833/
            <https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/1833/> :
            FAILURE
            https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/1836/
            <https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/1836/> :
            SUCCESS


            -Maciek

            from
            
https://jenkins.fd.io/job/vpp-csit-verify-virl-master/1841/consoleFull
            
<https://jenkins.fd.io/job/vpp-csit-verify-virl-master/1841/consoleFull>
            10:52:23 make[1]: Entering directory
            '/w/workspace/vpp-csit-verify-virl-master/build-root/deb'
            10:52:23 dh clean --with dkms --with systemd
            10:52:24 dh: error: cannot read debian/changelog: No such
            file or directory
            10:52:24 debian/rules:21: recipe for target 'clean' failed
            10:52:24 make[1]: *** [clean] Error 2
            10:52:24 make[1]: Leaving directory
            '/w/workspace/vpp-csit-verify-virl-master/build-root/deb'
            10:52:24 Makefile:1159: recipe for target 'distclean' failed
            10:52:24 make: *** [distclean] Error 2

            10:59:49 collect2: error: ld returned 1 exit status
            10:59:49 Makefile:551: recipe for target
            'libjvpp_registry.la <http://libjvpp_registry.la>' failed
            10:59:49 make[5]: *** [libjvpp_registry.la
            <http://libjvpp_registry.la>] Error 1
            10:59:49 make[5]: *** Waiting for unfinished jobs....
            11:00:00 make[5]: Leaving directory
            
'/w/workspace/vpp-csit-verify-virl-master/build-root/build-vpp-native/vpp-api/java'
            11:00:00 Makefile:445: recipe for target 'all' failed
            11:00:00 make[4]: *** [all] Error 2
            11:00:00 make[4]: Leaving directory
            
'/w/workspace/vpp-csit-verify-virl-master/build-root/build-vpp-native/vpp-api/java'
            11:00:00 Makefile:377: recipe for target 'all-recursive'
            failed
            11:00:00 make[3]: *** [all-recursive] Error 1
            11:00:00 make[3]: Leaving directory
            
'/w/workspace/vpp-csit-verify-virl-master/build-root/build-vpp-native/vpp-api'
            11:00:00 Makefile:699: recipe for target 'vpp-api-build'
            failed
            11:00:00 make[2]: *** [vpp-api-build] Error 2
            11:00:00 make[2]: Leaving directory
            '/w/workspace/vpp-csit-verify-virl-master/build-root'
            11:00:00
            /w/workspace/vpp-csit-verify-virl-master/build-data/platforms.mk:20
            <http://platforms.mk:20>: recipe for target 'install-deb'
            failed
            11:00:00 make[1]: *** [install-deb] Error 1
            11:00:00 make[1]: Leaving directory
            '/w/workspace/vpp-csit-verify-virl-master/build-root'
            11:00:00 Makefile:264: recipe for target 'pkg-deb' failed
            11:00:00 make: *** [pkg-deb] Error 2


            _______________________________________________
            csit-dev mailing list
            csit-...@lists.fd.io <mailto:csit-...@lists.fd.io>
            https://lists.fd.io/mailman/listinfo/csit-dev
            <https://lists.fd.io/mailman/listinfo/csit-dev>

        _______________________________________________ vpp-dev
        mailing list vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io>
        https://lists.fd.io/mailman/listinfo/vpp-dev
<https://lists.fd.io/mailman/listinfo/vpp-dev>
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
  • Re: [vpp-dev]... Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
    • Re: [vpp... Edward Warnicke
    • Re: [vpp... Dave Barach (dbarach)
    • Re: [vpp... Dave Wallace
      • Re: ... Edward Warnicke
        • ... Luke, Chris
          • ... Dave Wallace
        • ... Dave Wallace
          • ... Edward Warnicke
            • ... Dave Wallace
              • ... Dave Wallace
              • ... Jan Gelety -X (jgelety - PANTHEON TECHNOLOGIES at Cisco)
                • ... Dave Wallace
                • ... Edward Warnicke

Reply via email to